Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Telephone link type support in the Link plugin #2154

Closed
Kwadz opened this issue Jun 25, 2018 · 2 comments
Closed

Telephone link type support in the Link plugin #2154

Kwadz opened this issue Jun 25, 2018 · 2 comments
Labels
good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. plugin:link The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. target:major Any docs related issue that should be merged into a major branch. type:feature A feature request.
Milestone

Comments

@Kwadz
Copy link

Kwadz commented Jun 25, 2018

Type of report

Feature request

Provide description of the new feature

We should be able to select a telephone link type (<a href="tel:) in addition to the mail link type with the Link plugin.

@mlewand mlewand added type:feature A feature request. status:confirmed An issue confirmed by the development team. good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. plugin:link The plugin which probably causes the issue. target:major Any docs related issue that should be merged into a major branch. labels Jun 25, 2018
@mlewand mlewand changed the title Telephone link type is missing in Link plugin Telephone link type support in the Link plugin Jun 25, 2018
@mlewand
Copy link
Contributor

mlewand commented Jul 9, 2018

I'd like to see a semantically correct field being used for that field, so input[type=tel] makes the most sense here.

I don't think there should be a validation by default, but it would be nice if we'd expose an optional config option for a valid phone regexp.

The telephone type should be added as an option to the "Link Type" dropdown. There's no need to add it as an extra protocol in the "URL" type.

@mlewand
Copy link
Contributor

mlewand commented Jul 20, 2018

Note that the feature has landed on the major branch.

If you'd like to see it in action today, you can check our major branch preview sample in a true early adopter fashion 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. plugin:link The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. target:major Any docs related issue that should be merged into a major branch. type:feature A feature request.
Projects
None yet
Development

No branches or pull requests

3 participants