Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image ratio locking is too precise for resized images #2254

Closed
jacekbogdanski opened this issue Jul 24, 2018 · 0 comments
Closed

Image ratio locking is too precise for resized images #2254

jacekbogdanski opened this issue Jul 24, 2018 · 0 comments
Assignees
@jacekbogdanski
Labels
plugin:image The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. target:minor Any docs related issue that can be merged into a master or major branch. type:bug A bug.
Milestone
4.10.1

Comments

@jacekbogdanski
Copy link
Member

Type of report

Bug

Provide detailed reproduction steps (if any)

  1. Open editor sample with image plugin.
  2. Make sure that Lock ratio option is locked.
  3. Add image into an editor and change its ratio from even height into an odd height e.g from 1800x1200 to 500x333. You can use http://via.placeholder.com/1800x1200 for this test.
  4. Check if Lock ratio option is locked.

Expected result

Lock ratio option should be locked.

Actual result

Lock ratio option is not locked.

Other details

  • CKEditor version: 4.10.0
  • Installed CKEditor plugins: image
@jacekbogdanski jacekbogdanski added type:bug A bug. status:confirmed An issue confirmed by the development team. plugin:image The plugin which probably causes the issue. labels Jul 24, 2018
@jacekbogdanski jacekbogdanski self-assigned this Jul 24, 2018
@jacekbogdanski jacekbogdanski changed the title Image ratio is not correctly locked for images with odd pixel values Image ratio locking is too precise for resized images Jul 25, 2018
@jacekbogdanski jacekbogdanski mentioned this issue Jul 25, 2018
Merged
2 tasks
@mlewand mlewand added the target:minor Any docs related issue that can be merged into a master or major branch. label Aug 6, 2018
@Comandeer Comandeer added this to the 4.10.1 milestone Aug 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jacekbogdanski jacekbogdanski

Labels
plugin:image The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. target:minor Any docs related issue that can be merged into a master or major branch. type:bug A bug.
Projects
None yet
Milestone
4.10.1
Development

No branches or pull requests
3 participants
@Comandeer @mlewand @jacekbogdanski