Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Styling HTML comments in top level element result with extra paragraphs #2380

Closed
mlewand opened this issue Sep 5, 2018 · 1 comment
Closed
Labels
status:confirmed An issue confirmed by the development team. target:minor Any docs related issue that can be merged into a master or major branch. type:bug A bug.
Milestone

Comments

@mlewand
Copy link
Contributor

mlewand commented Sep 5, 2018

Type of report

Bug

Provide detailed reproduction steps (if any)

  1. Open CKEditor sample with source area, e.g. full preset sample.

  2. Go to source mode using "Source" button.

  3. Replace the source markup with the following:

    <p>foo</p>
    <!-- com -->
    <p>bar</p>
  4. Go back to WYSIWYG mode by clicking "Source" button once again.

  5. Focus the editor.

  6. Select all the contents (e.g. CTRL/CMD+A).

  7. Apply bold (e.g. CTRL/CMD+B).

  8. Click "Source" button once again to inspect the result markup.

Expected result

HTML markup should look like:

<p><strong>foo</strong></p>
<!-- com -->

<p><strong>bar</strong></p>

Actual result

<p><strong>foo</strong></p>

<p><strong><!-- com --></strong></p>

<p><strong><strong>bar</strong></strong></p>

<p>&nbsp;</p>
  • There's an unnecessary paragraph created around the comment node.
  • There's an extra paragraph at the end.

Other details

I can reproduce it in 4.4.2, didn't check earlier - so it doesn't look like a regression.

  • Browser: Any
  • OS: Any
@mlewand mlewand added type:bug A bug. status:confirmed An issue confirmed by the development team. target:minor Any docs related issue that can be merged into a master or major branch. labels Sep 5, 2018
@mlewand mlewand self-assigned this Sep 5, 2018
@mlewand mlewand removed their assignment Sep 6, 2018
@Comandeer
Copy link
Member

Merged into 4.10.2.

@Comandeer Comandeer added this to the 4.10.2 milestone Sep 6, 2018
@mlewand mlewand modified the milestones: 4.10.2, 4.11.0 Oct 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:confirmed An issue confirmed by the development team. target:minor Any docs related issue that can be merged into a master or major branch. type:bug A bug.
Projects
None yet
Development

No branches or pull requests

2 participants