Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emoji tooltip should show a human friendly label #2583

Closed
wwalc opened this issue Nov 7, 2018 · 1 comment · Fixed by #2656
Closed

Emoji tooltip should show a human friendly label #2583

wwalc opened this issue Nov 7, 2018 · 1 comment · Fixed by #2656
Labels
good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. plugin:autocomplete The plugin which probably causes the issue. plugin:emoji The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. type:feature A feature request.

Comments

@wwalc
Copy link
Member

wwalc commented Nov 7, 2018

The current way of presenting smileys looks pretty ugly:

screen shot 2018-11-07 at 09 07 04
@jacekbogdanski jacekbogdanski added type:feature A feature request. status:confirmed An issue confirmed by the development team. plugin:autocomplete The plugin which probably causes the issue. plugin:emoji The plugin which probably causes the issue. labels Nov 8, 2018
@jacekbogdanski
Copy link
Member

An implementation may require changes on the autocomplete side, at the current time it supports only changing list item template. We may use :before CSS for it, but I think that additional way to style autocomplete dropdown would be nice.

@mlewand mlewand added good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. target:major Any docs related issue that should be merged into a major branch. labels Dec 6, 2018
@engineering-this engineering-this self-assigned this Dec 6, 2018
@engineering-this engineering-this mentioned this issue Dec 6, 2018
Merged
2 tasks
@f1ames f1ames removed the target:major Any docs related issue that should be merged into a major branch. label Nov 12, 2019
This was referenced Aug 20, 2020
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. plugin:autocomplete The plugin which probably causes the issue. plugin:emoji The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. type:feature A feature request.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Show matched emoji name instead of an ID in emoji suggestion box ckeditor/ckeditor4
5 participants
@wwalc @f1ames @mlewand @jacekbogdanski @engineering-this