Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow user to indicate pasted content source #3646

Open
Dumluregn opened this issue Nov 12, 2019 · 2 comments
Open

Allow user to indicate pasted content source #3646

Dumluregn opened this issue Nov 12, 2019 · 2 comments
Labels
plugin:pastefromgdocs The plugin which probably causes the issue. plugin:pastefromword The plugin which probably causes the issue. plugin:pastetext The plugin which probably causes the issue. plugin:pastetools The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. type:feature A feature request.

Comments

@Dumluregn
Copy link
Contributor

Type of report

Feature request

Provide description of the new feature

During development of PfW and its peers we encounter a number of issues caused by our inability to easily detect the source (and therefore sometimes the format) of pasted data. That makes us use more or less ugly hacks to ensure the outcome will look as expected by user.

Instead we could give a minimal dose of responsibility to the user and give him the possibility to indicate the source of content so that we could handle it properly. That could save us time, lines of code, unexpected bugs and regressions (whoa, seems like a lot of profits). For now implementation is an open topic - we just know that it should be as user-friendly as possible.

Current ideas are as follows:

  1. Balloon toolbar displaying after pasting content allowing user to change source and compare the outcomes, similar to Word solution:

Screenshot 2019-11-12 at 13 23 57

CC @Comandeer as you have already created something like this during one of company hackathons - please show us what you've got :)
  1. Splitbutton (Unify pasting UI #3276):
    image
    There was also a broader discussion about Splitbutton plugin itself in Split button UI component #1679.

  2. Dialog displaying after detecting ambiguous content with options to choose from.

Sources for user to choose from may be:

Some important insights about handling pasting from different sources are also in #3258.

@Dumluregn Dumluregn added type:feature A feature request. status:confirmed An issue confirmed by the development team. plugin:pastefromword The plugin which probably causes the issue. plugin:pastetext The plugin which probably causes the issue. plugin:pastefromgdocs The plugin which probably causes the issue. plugin:pastetools The plugin which probably causes the issue. labels Nov 12, 2019
@Comandeer
Copy link
Member

Comandeer commented Nov 12, 2019

CC @Comandeer as you have already created something like this during one of company hackathons - please show us what you've got

The solution is available on https://github.com/ckeditor/ckeditor4/tree/hackathon-pastebutton

Personally I'm for joining 1 & 2. However I'm more for one paste button with all options, not two.

@f1ames
Copy link
Contributor

f1ames commented Jan 28, 2020

This will also allow use enabling PfLO in Safari (see #3809 (comment)).

@f1ames f1ames removed this from the Planning milestone Feb 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin:pastefromgdocs The plugin which probably causes the issue. plugin:pastefromword The plugin which probably causes the issue. plugin:pastetext The plugin which probably causes the issue. plugin:pastetools The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. type:feature A feature request.
Projects
None yet
Development

No branches or pull requests

3 participants