Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose colorbutton commands #3727

Closed
jacekbogdanski opened this issue Dec 11, 2019 · 0 comments · Fixed by #3405
Closed

Expose colorbutton commands #3727

jacekbogdanski opened this issue Dec 11, 2019 · 0 comments · Fixed by #3405
Assignees
@msamsel
Labels
plugin:colorbutton The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. type:feature A feature request.
Milestone
Iteration 2019-1 ...

Comments

@jacekbogdanski
Copy link
Member

jacekbogdanski commented Dec 11, 2019 •
edited by msamsel
Loading

Type of report

Feature request

Provide description of the new feature

Color Button should expose back and front text color change as dedicated commands as an addition to internal content style manipulation.

Specification:

  • color button registers 'textColor' and 'bgColor' commands.
  • color commands takes as data an object with a newStyle key.
    • new style should be empty if we want to remove styles
    • new style should be an instance of CKEDITOR.style if we want to apply new style
  • [extra] color command should should be contextSensitive and react on selection changes
  • UI state should react to changes of related color command state

Extracted from #3306, read #3306 (comment) for more details about implementation.
@jacekbogdanski jacekbogdanski added type:feature A feature request. status:confirmed An issue confirmed by the development team. plugin:colorbutton The plugin which probably causes the issue. labels Dec 11, 2019
@jacekbogdanski jacekbogdanski added this to the Iteration 2019-1 milestone Dec 11, 2019
@msamsel msamsel mentioned this issue Dec 11, 2019
Merged
2 tasks
@jacekbogdanski jacekbogdanski mentioned this issue Dec 11, 2019
Closed
@msamsel msamsel self-assigned this Dec 11, 2019
@jacekbogdanski jacekbogdanski mentioned this issue Dec 18, 2019
Closed
@f1ames f1ames mentioned this issue Apr 20, 2020
Closed
This was referenced Aug 20, 2020
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@msamsel msamsel

Labels
plugin:colorbutton The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. type:feature A feature request.
Projects
None yet
Milestone
Iteration 2019-1 (4.14.0)
Development

Successfully merging a pull request may close this issue.

Implement textColor and bgColor commands ckeditor/ckeditor4
2 participants
@msamsel @jacekbogdanski