Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refresh colorbutton state during selection change #3748

Closed
jacekbogdanski opened this issue Dec 20, 2019 · 0 comments · Fixed by #3405
Closed

Refresh colorbutton state during selection change #3748

jacekbogdanski opened this issue Dec 20, 2019 · 0 comments · Fixed by #3405
Labels
plugin:colorbutton The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. type:feature A feature request.
Milestone
Iteration 2019-0 ...

Comments

@jacekbogdanski
Copy link
Member

jacekbogdanski commented Dec 20, 2019 •
edited
Loading

Type of report

Feature request

Provide description of the new feature

Currently, colorbutton doesn't update its state during selection change, which lacks correct feedback for a user. We could improve this behavior by making button active when selection is placed inside color-styled content.
@jacekbogdanski jacekbogdanski added type:feature A feature request. status:confirmed An issue confirmed by the development team. plugin:colorbutton The plugin which probably causes the issue. labels Dec 20, 2019
@msamsel msamsel mentioned this issue Dec 20, 2019
Merged
2 tasks
@jacekbogdanski jacekbogdanski added this to the 4.14.0 milestone Dec 20, 2019
@f1ames f1ames mentioned this issue Apr 20, 2020
Closed
This was referenced Aug 20, 2020
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
plugin:colorbutton The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. type:feature A feature request.
Projects
None yet
Milestone
Iteration 2019-0 (4.14.0)
Development

Successfully merging a pull request may close this issue.

Implement textColor and bgColor commands ckeditor/ckeditor4
2 participants
@f1ames @jacekbogdanski