Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image copied in clipboard is not insterted as base64 when not using uploadimage plugin #3757

Closed
SuperPat45 opened this issue Jan 6, 2020 · 9 comments · Fixed by #4662
Closed
Assignees
Labels
browser:firefox The issue can only be reproduced in the Firefox browser. plugin:clipboard The plugin which probably causes the issue. regression This issue is a regression. status:confirmed An issue confirmed by the development team. type:bug A bug.
Milestone

Comments

@SuperPat45
Copy link
Contributor

Are you reporting a feature request or a bug?

Feature request

Provide detailed reproduction steps (if any)

  1. We are not using uploadimage, nor easyimage
  2. Press print screen
  3. Paste with Ctrl+V in ckeditor

Expected result

Image must be inserted as base64 like as when I copy/paste a file image

Actual result

Nothing when uploadimage not used

Other details

  • Browser: Firefox 71
  • OS: Windows
  • CKEditor version: 4.13.1
  • Installed CKEditor plugins: base64image and no uploadimage, nor easyimage
@Dumluregn
Copy link
Contributor

Hello, I'm not sure where is the problem - do you have a problem with base64image plugin?

@SuperPat45
Copy link
Contributor Author

base64image is not the problem,
It is ckeditor who is unable to paste an image content in a clipboard without the uploadimage plugin.
We can insert only an image file copied in the clipboard

@Dumluregn
Copy link
Contributor

Ok. I managed to reproduce this issue also in Chrome using CDEditor CDN on MacOS: press CTRL+CMD+SHIFT+3 which will store print screen in clipboard and then try to paste into editor -nothing will happen (to compare try the same e.g. in File Upload demo - but note it's config doesn't insert image in base64 format). Could you tell why you don't use uploadimage plugin?

@SuperPat45
Copy link
Contributor Author

I currently don't use uploadimage because I need image inserted as base64 in the HTML. This is why I use the base64image plugin.

@f1ames
Copy link
Contributor

f1ames commented Jan 20, 2020

@SuperPat45 since for image handling you are using base64image plugin isn't it the issue with the plugin itself that it can't correctly handle images in such case.

The base64image plugin is the 3rd-party plugin so the issue should be reported to plugin authors directly (see https://ckeditor.com/cke4/addon/base64image).

@SuperPat45
Copy link
Contributor Author

SuperPat45 commented Jan 20, 2020

It would be better if I didn't have to use any image plugins to paste image content of file.
It worked fine in ckeditor 4.13 but only on firefox.

@f1ames
Copy link
Contributor

f1ames commented Jan 20, 2020

Ok, I see the main point of this issue is that it worked fine without any additional plugins on Firefox with CKEditor 4 4.13.0 and stopped working in 4.13.1. Tested and confirmed that on Windows 7 with Firefox 72.

It doesn't work in Chrome like that (both in 4.13.0 and 4.13.1) so Firefox is probably the only supported browser which can handle this situation natively.

I suppose, we could treat it as a regression in Firefox then. And our suspect would be #3639.

@f1ames f1ames added browser:firefox The issue can only be reproduced in the Firefox browser. plugin:clipboard The plugin which probably causes the issue. regression This issue is a regression. status:confirmed An issue confirmed by the development team. type:bug A bug. and removed status:pending labels Jan 20, 2020
@Comandeer Comandeer added the status:blocked An issue which development is blocked by another issue (internal or external one). label Apr 2, 2021
@Comandeer
Copy link
Member

Blocked by #4604.

@f1ames f1ames added the size:S label Apr 9, 2021
@f1ames f1ames removed the status:blocked An issue which development is blocked by another issue (internal or external one). label Apr 23, 2021
@Comandeer Comandeer self-assigned this Apr 30, 2021
@CKEditorBot
Copy link
Collaborator

Closed in #4662

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
browser:firefox The issue can only be reproduced in the Firefox browser. plugin:clipboard The plugin which probably causes the issue. regression This issue is a regression. status:confirmed An issue confirmed by the development team. type:bug A bug.
Projects
None yet
5 participants