Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify image processing for paste from word and libre office #3782

Closed
msamsel opened this issue Jan 15, 2020 · 0 comments · Fixed by #4291
Closed

Unify image processing for paste from word and libre office #3782

msamsel opened this issue Jan 15, 2020 · 0 comments · Fixed by #4291
Assignees
@Comandeer
Labels
plugin:pastefromword The plugin which probably causes the issue. plugin:pastetools The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. type:feature A feature request.
Milestone
4.16.0

Comments

@msamsel
Copy link
Contributor

msamsel commented Jan 15, 2020

Type of report

Feature request

Provide a description of the new feature

Issue extracted from: #3624 (comment)

During PFLO development the process of embedding images was extracted and moved to a separate general pastetools filter. Process of transforming images in Word and Libre Office is very similar. Because introducing Paste From Libre Office plugin wasn't sound as good candidate to refactor image processing of Paste From Word, the issue is extracted here.
The idea is to:

  1. Extend plugins/pastettools/filter/image.js with support for images pasted from Word.
  2. Remove logic responsible for embedding images from PFW plugin
  3. Link external image filter to PFW in a simillar way as it is done for PFLO:

    ckeditor4/plugins/pastefromlibreoffice/plugin.js

    Lines 21 to 25 in 446da83

    filters: [
    CKEDITOR.getUrl( pasteToolsPath + 'filter/common.js' ),
    CKEDITOR.getUrl( pasteToolsPath + 'filter/image.js' ),
    CKEDITOR.getUrl( path + 'filter/default.js' )
    ],
@msamsel msamsel added type:feature A feature request. status:confirmed An issue confirmed by the development team. plugin:pastefromword The plugin which probably causes the issue. plugin:pastetools The plugin which probably causes the issue. labels Jan 15, 2020
@msamsel msamsel mentioned this issue Jan 15, 2020
Merged
2 tasks
@smatteoda smatteoda mentioned this issue May 29, 2020
Closed
@Comandeer Comandeer mentioned this issue Sep 23, 2020
Merged
3 tasks
@f1ames f1ames added this to the 4.16.0 milestone Nov 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Comandeer Comandeer

Labels
plugin:pastefromword The plugin which probably causes the issue. plugin:pastetools The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. type:feature A feature request.
Projects
None yet
Milestone
4.16.0
Development

Successfully merging a pull request may close this issue.

Improve importing images from Microsoft Word ckeditor/ckeditor4
3 participants
@f1ames @Comandeer @msamsel