Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anchor is duplicated when edited #3863

Closed
AlexanderMur opened this issue Feb 16, 2020 · 11 comments
Closed

Anchor is duplicated when edited #3863

AlexanderMur opened this issue Feb 16, 2020 · 11 comments
Assignees
Labels
plugin:link The plugin which probably causes the issue. regression This issue is a regression. status:confirmed An issue confirmed by the development team. type:bug A bug.
Milestone

Comments

@AlexanderMur
Copy link

Type of report

Bug

Provide detailed reproduction steps (if any)

  1. go to https://ckeditor.com/latest/samples/index.html
  2. make some bold text
  3. make it anchor
  4. try to edit anchor - double click
  5. press ok

example: https://i.gyazo.com/fa442d930a3b59eec754ca0b5956b8b5.mp4

Every time when you anchor is edited with style like bold underline etc. - this makes a doubled anchor instead of just editing.

Expected result

anchor is edited

Actual result

anchor is doubled

Other details

  • Browser: Chrome 80.0.3987.106
  • OS: Windows 10 1903
  • CKEditor version: 4
@AlexanderMur AlexanderMur added the type:bug A bug. label Feb 16, 2020
@Comandeer Comandeer added plugin:link The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. labels Feb 17, 2020
@Comandeer
Copy link
Member

I can confirm the issue. Seems like internal getSelectedAnchor function assumes that text can be surrounded only by the link itself, not considering more complex situations like:

<a><strong>Text</strong></a>

@AlexanderMur
Copy link
Author

How can I fix this without modifying source code?

@deyankush
Copy link

deyankush commented Jan 20, 2021

@Comandeer any updates on this defect? I am facing the same issue. This was working in v4.7. Since we migrated to v4.13 its stopped working.

@Dumluregn
Copy link
Contributor

Hello @deyankush, thank you for bringing to our attention that it's a regression. It was indeed introduced in 4.13.0, which means we probably try to handle it in the near future.

@Dumluregn Dumluregn added the regression This issue is a regression. label Jan 20, 2021
@vinaydhakre
Copy link

@Dumluregn - I am facing the same issue. Could you take this defect on priority so that we can get this fix ASAP?

@Dumluregn
Copy link
Contributor

Unfortunately we've just froze the branches before release, so this issue will have to wait for the next one. However if nothing unexpected happens we should be able to fix this for then.

@vaibhav198989
Copy link

@Dumluregn when is the next release expected ?

@deyankush
Copy link

Hello @deyankush, thank you for bringing to our attention that it's a regression. It was indeed introduced in 4.13.0, which means we probably try to handle it in the near future.

Is it possible to get a patch on 4.13?

@Dumluregn
Copy link
Contributor

@vaibhav198989 we do not have a date set, probably in a few months.
@deyankush we do not provide backwards patches, but if you have a commercial license you can reach our support team for workaround or help in your own development of this fix.

@Dumluregn Dumluregn added size:M and removed size:S labels Jan 21, 2021
@deyankush
Copy link

@Dumluregn this commit seems to have caused the regression: 7c93a77
@jacekbogdanski could you please confirm?

@jacekbogdanski
Copy link
Member

Closed in #4733

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin:link The plugin which probably causes the issue. regression This issue is a regression. status:confirmed An issue confirmed by the development team. type:bug A bug.
Projects
None yet
Development

No branches or pull requests

9 participants