Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Screen Readers don't announce dropdown is collapsed/expanded #4007

Closed
jswiderski opened this issue Apr 28, 2020 · 1 comment
Closed

Screen Readers don't announce dropdown is collapsed/expanded #4007

jswiderski opened this issue Apr 28, 2020 · 1 comment
Assignees
Labels
status:confirmed An issue confirmed by the development team. support:2 An issue reported by a commercially licensed client. type:bug A bug.
Milestone

Comments

@jswiderski
Copy link
Contributor

Type of report

Bug

Provide detailed reproduction steps (if any)

  1. Open CKEditor with Screen Reader other than JAWS enabled
  2. Press Alt+F10 to move focus to toolbar
  3. Keep Pressing Tab until you reach Styles, Font, Format or Size dropdown and press Enter once you do that.

Expected result

Screen Reader should announce that dropdown is collapsed and once Enter is pressed, it should announce the it has been expanded.

Actual result

Except for JAWS which informs about dropdown navigation in its own way, nothing happens.
It looks like the link element of button dropdown is missing the aria-expanded attribute.

Other details

  • Browser: Any
  • OS: Any
  • CKEditor version: 4.14.0
  • Installed CKEditor plugins: N/A

By adding below code in line https://github.com/ckeditor/ckeditor4/blob/major/plugins/richcombo/plugin.js#L382 there is an improvement:

var linkEl = el.getElementsByTag( 'a' ).getItem( 0 );
	if( linkEl )
		linkEl.setAttribute( 'aria-expanded', state == CKEDITOR.TRISTATE_ON );	

ChromeVox and NVDA - announce list is collapsed/expanded
Narrator - only announced the list is collapsed
JAWS ignores the attribute but announced how to navigate through dropdown in its own way.

@jswiderski jswiderski added type:bug A bug. support:2 An issue reported by a commercially licensed client. status:confirmed An issue confirmed by the development team. labels Apr 28, 2020
@Dumluregn Dumluregn self-assigned this Jul 3, 2020
@jacekbogdanski
Copy link
Member

Closed in #4148

@f1ames f1ames added this to the 4.15.0 milestone Aug 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:confirmed An issue confirmed by the development team. support:2 An issue reported by a commercially licensed client. type:bug A bug.
Projects
None yet
Development

No branches or pull requests

4 participants