Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Embed widget nested inside another widget gets URL broken on mode change #4060

Closed
jswiderski opened this issue May 18, 2020 · 0 comments · Fixed by #4227
Closed

Embed widget nested inside another widget gets URL broken on mode change #4060

jswiderski opened this issue May 18, 2020 · 0 comments · Fixed by #4227
Assignees
@Comandeer
Labels
plugin:autoembed The plugin which probably causes the issue. plugin:embed The plugin which probably causes the issue. plugin:widget The plugin which probably causes the issue. regression This issue is a regression. status:confirmed An issue confirmed by the development team. support:3 An issue reported by a commercially licensed client. type:bug A bug.
Milestone
4.15.0

Comments

@jswiderski
Copy link
Contributor

Type of report

Bug

Provide detailed reproduction steps (if any)

https://codepen.io/j_swiderski/pen/rNOQGdx

  1. Open the following lik: https://codepen.io/j_swiderski/pen/rNOQGdx
  2. Switch to source mode and back couple of times.

Expected result

The URL to script of the nested widget should remains unchanged - <script async="" charset="utf-8" src="//if-cdn.com/embed.js"></script></div>.

Actual result

The URL to script of the nested widget should changes with every mode change e.g. <!--{C}%3C!%2D%2D%253Cscript%2520async%253D%2522%2522%2520charset%253D%2522utf-8%2522%2520src%253D%2522%252F%252Fif-cdn.com%252Fembed.js%2522%253E%253C%252Fscript%253E%2D%2D%3E--></div>

Other details

  • Browser: Any
  • OS: Any
  • CKEditor version: 4.14.0
  • Installed CKEditor plugins: embed, autoembed,widget

This is a recent regression
@jswiderski jswiderski added type:bug A bug. status:confirmed An issue confirmed by the development team. plugin:embed The plugin which probably causes the issue. plugin:widget The plugin which probably causes the issue. regression This issue is a regression. plugin:autoembed The plugin which probably causes the issue. labels May 18, 2020
@martynawierzbicka martynawierzbicka added the support:1 An issue reported by a commercially licensed client. label May 19, 2020
@jacekbogdanski jacekbogdanski self-assigned this Jun 2, 2020
@jacekbogdanski jacekbogdanski removed their assignment Jul 6, 2020
@Comandeer Comandeer self-assigned this Aug 17, 2020
@Comandeer Comandeer mentioned this issue Aug 24, 2020
Merged
3 tasks
@f1ames f1ames added this to the 4.15.0 milestone Aug 31, 2020
@lslowikowska lslowikowska added support:3 An issue reported by a commercially licensed client. and removed support:1 An issue reported by a commercially licensed client. labels Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Comandeer Comandeer

Labels
plugin:autoembed The plugin which probably causes the issue. plugin:embed The plugin which probably causes the issue. plugin:widget The plugin which probably causes the issue. regression This issue is a regression. status:confirmed An issue confirmed by the development team. support:3 An issue reported by a commercially licensed client. type:bug A bug.
Projects
None yet
Milestone
4.15.0
Development

Successfully merging a pull request may close this issue.

Fix for double escaping content in nested editables ckeditor/ckeditor4
6 participants
@f1ames @Comandeer @jswiderski @jacekbogdanski @lslowikowska @martynawierzbicka