Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect buttons labels in High Contrast mode #4422

Closed
Comandeer opened this issue Dec 7, 2020 · 3 comments
Closed

Incorrect buttons labels in High Contrast mode #4422

Comandeer opened this issue Dec 7, 2020 · 3 comments
Assignees
@sculpt0r
Labels
accessibility Issue related to accessibility. core The issue is caused by the editor core code. good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. status:confirmed An issue confirmed by the development team. type:bug A bug.
Milestone
4.16.0

Comments

@Comandeer
Copy link
Member

Type of report

Bug

Provide detailed reproduction steps (if any)

  1. Open the editor in High Contrast mode.

Expected result

There is a space between the button's name and additional information (e.g. about keyboard shortcut).

Actual result

There is no space between the button's name and additional information:
Buttons in the editor's UI with incorrect labels, e.g. "BoldKeyboard shortcut Ctrl+B"

Other details

  • CKEditor version: 4.6.0+
@Comandeer Comandeer added type:bug A bug. status:confirmed An issue confirmed by the development team. accessibility Issue related to accessibility. core The issue is caused by the editor core code. labels Dec 7, 2020
@f1ames f1ames added size:XS good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. labels Dec 7, 2020
@96RadhikaJadhav
Copy link

@Comandeer Can I give a try to this?

@f1ames
Copy link
Contributor

f1ames commented Dec 10, 2020

@96RadhikaJadhav feel free to give it a try and create a PR 👍 You may refer to our Contributing guide.

@sculpt0r sculpt0r self-assigned this Dec 14, 2020
This was referenced Dec 14, 2020
Merged
Open
@CKEditorBot
Copy link
Collaborator

Closed in #4436

@CKEditorBot CKEditorBot added this to the 4.15.2 milestone Dec 21, 2020
@f1ames f1ames modified the milestones: 4.15.2, 4.16.0 Jan 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sculpt0r sculpt0r

Labels
accessibility Issue related to accessibility. core The issue is caused by the editor core code. good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. status:confirmed An issue confirmed by the development team. type:bug A bug.
Projects
None yet
Milestone
4.16.0
Development

No branches or pull requests
5 participants
@f1ames @Comandeer @sculpt0r @CKEditorBot @96RadhikaJadhav