Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor gone after pasting into an editor within a table #460

Closed
hponka opened this issue Jun 2, 2017 · 7 comments
Closed

Editor gone after pasting into an editor within a table #460

hponka opened this issue Jun 2, 2017 · 7 comments
Assignees
Labels
plugin:tableselection The plugin which probably causes the issue. regression This issue is a regression. status:confirmed An issue confirmed by the development team. type:bug A bug.
Milestone

Comments

@hponka
Copy link

hponka commented Jun 2, 2017

Are you reporting a feature or a bug?

Bug

Provide detailed reproduction steps (if any)

It happens every times with CKEditor 4.7.0 full preset (dynamically loaded inline editor) when you:

  1. open https://codepen.io/anon/pen/wewbmj
  2. select whole editor content
  3. press backspace
  4. then paste some content (e.g. pure text)

But it doesn't happens if you remove tableselection plugin.

Expected result

Content is pasted properly.

Actual result

Editor disappears and only pasted content is showing.

Other details

  • Browser: Chrome 58.0.3029.110
  • OS: Windows 7 Pro
  • CKEditor version: 4.7.0
  • Installed CKEditor plugins: full preset
@mlewand
Copy link
Contributor

mlewand commented Jun 2, 2017

@hponka I can't repro it, could you try to check https://codepen.io/mlewand/pen/WOeBvM ?

There's an empty inline editor (just below the first paragraph)

  1. Click empty inline editor (just below the first paragraph).
  2. Press backspace.
  3. Paste text.

The content is visible.

@hponka
Copy link
Author

hponka commented Jun 2, 2017

@mlewand It happens when editor is in table cell: https://codepen.io/anon/pen/wewbmj

@mlewand mlewand added status:confirmed An issue confirmed by the development team. type:bug A bug. and removed status:pending labels Jun 2, 2017
@mlewand
Copy link
Contributor

mlewand commented Jun 2, 2017

Thank you @hponka now I can reproduce the issue.

@mlewand mlewand changed the title Paste problem with Ckeditor 4.7.0 tableselection plugin Paste problem with CKEditor 4.7.0 tableselection plugin Jun 7, 2017
@mlewand mlewand added the regression This issue is a regression. label Jun 14, 2017
@mlewand mlewand added this to the 4.7.2 milestone Jun 14, 2017
@mlewand mlewand modified the milestones: 4.7.3, 4.7.2 Aug 9, 2017
@Comandeer
Copy link
Member

It seems that changes connected with handling pasting in tableselection plugin that were made in 4.7.2 fixed this issue: https://codepen.io/anon/pen/VzXxzK

@mlewand
Copy link
Contributor

mlewand commented Aug 24, 2017

@Comandeer that's right I also can no longer reproduce this issue from version 4.7.2. @Mgsy can I ask you to do manual test in order to (tripple) confirm that the issue has been fixed?

If it is we need to move this ticket to 4.7.2 milestone, and correct changelog entry.

@mlewand mlewand changed the title Paste problem with CKEditor 4.7.0 tableselection plugin Editor gone after pasting into an editor within a table Aug 24, 2017
@mlewand mlewand added the plugin:tableselection The plugin which probably causes the issue. label Aug 24, 2017
@Mgsy
Copy link
Member

Mgsy commented Aug 25, 2017

@Mgsy can I ask you to do manual test in order to (tripple) confirm that the issue has been fixed?

I can confirm that this issue doesn't occur anymore.

@mlewand
Copy link
Contributor

mlewand commented Aug 25, 2017

Thanks for confirming! It was most likely fixed with this major PR: #694.

Added changelog entry in a3483c3.

@mlewand mlewand closed this as completed Aug 25, 2017
@mlewand mlewand modified the milestones: 4.7.2, 4.7.3 Aug 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin:tableselection The plugin which probably causes the issue. regression This issue is a regression. status:confirmed An issue confirmed by the development team. type:bug A bug.
Projects
None yet
Development

No branches or pull requests

4 participants