Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Toolbar configurator undefined error thrown with some 3rd-party plugins #5014

Closed
SuperPat45 opened this issue Jan 3, 2022 · 2 comments · Fixed by #5013
Closed

Toolbar configurator undefined error thrown with some 3rd-party plugins #5014

SuperPat45 opened this issue Jan 3, 2022 · 2 comments · Fixed by #5013
Labels
easy Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. status:confirmed An issue confirmed by the development team. type:bug A bug.
Milestone
4.17.2

Comments

@SuperPat45
Copy link
Contributor

SuperPat45 commented Jan 3, 2022 •
edited
Loading

Type of report

Bug

Provide detailed reproduction steps (if any)

  1. Use CKEditor online builder with the Zoom plugins and generate
  2. Extract and launch the samples/toolbarconfigurator/index.html

Expected result

What is the expected result of the above steps?
Toolbar should work anyway

Actual result

Because the zoom plugin does not define any toolbar option when they add its richcombo button in the toolbar,
the toolbar configurator does not work, and an exception appear in the console:

Uncaught TypeError: currBtn.toolbar is undefined
groupButtons file:///C:/ckeditor/samples/toolbarconfigurator/js/fulltoolbareditor.js:215
init file:///C:/ckeditor/samples/toolbarconfigurator/js/fulltoolbareditor.js:54

Other details

  • Browser: Firefox 95
  • OS: Windows
  • CKEditor version: 4.17.1
  • Installed CKEditor plugins: Zoom
@SuperPat45 SuperPat45 added the type:bug A bug. label Jan 3, 2022
@SuperPat45 SuperPat45 mentioned this issue Jan 3, 2022
Merged
3 tasks
@sculpt0r
Copy link
Contributor

sculpt0r commented Jan 7, 2022

Hi @SuperPat45

I can confirm this issue. Not only FF, but chrome fails as well. The nature of this bug is not related to any browser. Thank you for the report.

@sculpt0r sculpt0r added size:XXS status:confirmed An issue confirmed by the development team. easy Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. labels Jan 7, 2022
@CKEditorBot
Copy link
Collaborator

Closed in #5013

@CKEditorBot CKEditorBot added this to the 4.17.2 milestone Jan 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
easy Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. status:confirmed An issue confirmed by the development team. type:bug A bug.
Projects
None yet
Milestone
4.17.2
Development

Successfully merging a pull request may close this issue.

Fix toolbar configurator undefined error
3 participants
@sculpt0r @SuperPat45 @CKEditorBot