Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update license banners #5037

Merged
merged 11 commits into from
Jan 25, 2022
Merged

Update license banners #5037

merged 11 commits into from
Jan 25, 2022

Conversation

Comandeer
Copy link
Member

What is the purpose of this pull request?

Task

Does your PR contain necessary tests?

All patches that change the editor code must include tests. You can always read more
on PR testing,
how to set the testing environment and
how to create tests
in the official CKEditor documentation.

This PR contains

  • Unit tests
  • Manual tests

Did you follow the CKEditor 4 code style guide?

Your code should follow the guidelines from the CKEditor 4 code style guide which helps keep the entire codebase consistent.

  • PR is consistent with the code style guide

What is the proposed changelog entry for this pull request?

skip

What changes did you make?

The PR contains updates of license banners in all files.

@Comandeer
Copy link
Member Author

I've updated the license update script to ignore git ignored files and files inside git submodules. It's helpful when running the script in other repos, e.g. ckeditor4-docs.

I've also added a simple console.log() to know which files are touched.

Copy link
Contributor

@sculpt0r sculpt0r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. However, I found a few places that should be updated. The date was updated, but due to links - they don't match to old company regexp:
image

Due to ☝️ maybe we can just update them manually without updating the regexp? Since tif we are going to ever change the company name again - it will be a different regexp anyway.

@Comandeer
Copy link
Member Author

maybe we can just update them manually without updating the regexp?

Never! I've updated the regex accordingly 😛I've also added .json files to files allowed to be updated.

@sculpt0r
Copy link
Contributor

LGTM 🎉

The RegExp looks charming... But I guess that's the nature of RegExp's :D

@sculpt0r sculpt0r merged commit a6dbe74 into master Jan 25, 2022
@sculpt0r sculpt0r deleted the license-update branch January 25, 2022 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants