-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update license banners #5037
Update license banners #5037
Conversation
I've updated the license update script to ignore git ignored files and files inside git submodules. It's helpful when running the script in other repos, e.g. I've also added a simple |
42b171b
to
421c0d7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good. However, I found a few places that should be updated. The date was updated, but due to links - they don't match to old company regexp:
Due to ☝️ maybe we can just update them manually without updating the regexp? Since tif we are going to ever change the company name again - it will be a different regexp anyway.
…urrently updated.
421c0d7
to
0a00dea
Compare
Never! I've updated the regex accordingly 😛I've also added |
LGTM 🎉 The RegExp looks charming... But I guess that's the nature of RegExp's :D |
What is the purpose of this pull request?
Task
Does your PR contain necessary tests?
All patches that change the editor code must include tests. You can always read more
on PR testing,
how to set the testing environment and
how to create tests
in the official CKEditor documentation.
This PR contains
Did you follow the CKEditor 4 code style guide?
Your code should follow the guidelines from the CKEditor 4 code style guide which helps keep the entire codebase consistent.
What is the proposed changelog entry for this pull request?
skip
What changes did you make?
The PR contains updates of license banners in all files.