feature plan about document.domain in ckeditor

[Ravikantsolanki]

Currently most of the browsers are going to deprecate the setters for document.domain method.

Here mentioning about deprecation https://developer.mozilla.org/en-US/docs/Web/API/Document/domain. Please refer this article as well.

However, ckeditor.js or others js are still using document.domain method to set document.domain. Please refer the below link where you will find out the document.domain setter.

ckeditor4/core/tools.js

Line 1410 in f631006

document.domain = domain;

We wanted to know your feature plan about document.domain. Means are you planning to use any alternative way or it will still be used in feature? In that case it might be create an issue if setters for document.domain will be deprecated.

[Comandeer]

As it's stated in the documentation of this method, it's used only in Internet Explorer, and due to that it won't be affected by the deprecation.

However, it seems that there is one place in our codebase where this method is accidentally used also in Firefox →

ckeditor4/plugins/preview/plugin.js

Line 224 in 0150a16

( '(' + CKEDITOR.tools.fixDomain + ')();' ).replace( /\/\/.*?\n/g, '' ).replace( /parent\./g, 'window.opener.' ) +

That's probably something we need to fix.

[tmajumda1]

@Comandeer
In the meantime, say if document.domain setters stop working completely, will it have any major impact in CKEDITOR?

[Comandeer]

As I already said, we use it only in the Internet Explorer which means that disabling setters for document.domain shouldn't be an issue for us.