Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The change event is not fired after uploading the image #5414

Closed
Comandeer opened this issue Feb 6, 2023 · 0 comments · Fixed by #5415
Closed

The change event is not fired after uploading the image #5414

Comandeer opened this issue Feb 6, 2023 · 0 comments · Fixed by #5415
Assignees
@Comandeer
Labels
plugin:easyimage The plugin which probably causes the issue. plugin:filetools The plugin which probably causes the issue. plugin:uploadfile The plugin which probably causes the issue. plugin:uploadimage The plugin which probably causes the issue. plugin:uploadwidget The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. type:bug A bug.

Comments

@Comandeer
Copy link
Member

Type of report

Bug

Provide detailed reproduction steps (if any)

  1. Open https://jsfiddle.net/Comandeer/zrLst2nx/
  2. Open console.
  3. Paste image into the editor.

Expected result

The change event is logged twice: for pasting an image and for replacing its URL with the uploaded one.

Actual result

The change event is logged once: for pasting an image.

Other details

  • Browser: N/A
  • OS: N/A
  • CKEditor version: 4.20.1 (however it applies also to older ones)
  • Installed CKEditor plugins: uploadwidget, filetools and dependent ones

It seems to be connected with the fact that the change event is not fired after completing the upload/replacing the placeholder image with the uploaded one.

See also ckeditor/ckeditor4-angular#237.
@Comandeer Comandeer added type:bug A bug. status:confirmed An issue confirmed by the development team. plugin:uploadfile The plugin which probably causes the issue. plugin:uploadimage The plugin which probably causes the issue. plugin:uploadwidget The plugin which probably causes the issue. plugin:filetools The plugin which probably causes the issue. plugin:easyimage The plugin which probably causes the issue. labels Feb 6, 2023
@Comandeer Comandeer self-assigned this Feb 6, 2023
@Comandeer Comandeer mentioned this issue Feb 6, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Comandeer Comandeer

Labels
plugin:easyimage The plugin which probably causes the issue. plugin:filetools The plugin which probably causes the issue. plugin:uploadfile The plugin which probably causes the issue. plugin:uploadimage The plugin which probably causes the issue. plugin:uploadwidget The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. type:bug A bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fire the change event after uploading is done ckeditor/ckeditor4
1 participant
@Comandeer