Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unwanted "cke_table-faked-selection-table" class in table properties dialog box #579

Closed
smartcorestudio opened this issue Jun 29, 2017 · 1 comment
Closed

Unwanted "cke_table-faked-selection-table" class in table properties dialog box #579

smartcorestudio opened this issue Jun 29, 2017 · 1 comment
Assignees
@msamsel
Labels
good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. plugin:tableselection The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. type:bug A bug.
Milestone
4.7.2

Comments

@smartcorestudio
Copy link

Are you reporting a feature or a bug?

Bug

Provide detailed reproduction steps (if any)

  1. Select some cells in the table. For example you can use table from this page: http://sdk.ckeditor.com/samples/fullpreset.html
  2. Go to the 2nd tab in the "Table properties" dialog box

Expected result

In the "CSS classes" input field you should see only actual classes, not the virtual ones. In this particular case the field should be empty

Actual result

In the "CSS classes" input field you'll see "cke_table-faked-selection-table". It can confuse some users

Other details

  • Browser: Firefox
  • OS: Windows
  • CKEditor version: 4.7.0 at least
  • Installed CKEditor plugins: advanced tab, table selection

2017-06-29 14_05_28-ckeditor sdk samples full preset
@mlewand mlewand added plugin:tableselection The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. type:bug A bug. good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. labels Jun 29, 2017
@mlewand
Copy link
Contributor

mlewand commented Jun 29, 2017

A trivial fix is just to use data- attribute, and apply styling using this attribute. 🙂

@msamsel msamsel self-assigned this Jun 29, 2017
@msamsel msamsel mentioned this issue Jul 3, 2017
Merged
2 tasks
@msamsel msamsel added this to the 4.7.2 milestone Jul 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@msamsel msamsel

Labels
good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. plugin:tableselection The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. type:bug A bug.
Projects
None yet
Milestone
4.7.2
Development

No branches or pull requests
3 participants
@smartcorestudio @mlewand @msamsel