Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Method elementPath.contains() incorrectly excludes root when fromTop is set to true #684

Closed
mlewand opened this issue Jul 27, 2017 · 0 comments
Closed

Method elementPath.contains() incorrectly excludes root when fromTop is set to true #684

mlewand opened this issue Jul 27, 2017 · 0 comments
Labels
good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. status:confirmed An issue confirmed by the development team. type:bug A bug.
Milestone
4.7.2

Comments

@mlewand
Copy link
Contributor

mlewand commented Jul 27, 2017 •
edited
Loading

Are you reporting a feature or a bug?

Bug

Check if the issue is already reported

https://dev.ckeditor.com/ticket/14603

Provide detailed reproduction steps (if any)

Method elementPath.contains() incorrectly excludes root when fromTop is set to true.

  1. Set a following HTML:
<p><b>fo^o</b></p>
  1. Check whether a range (set above) contains a b element with a following call:
path.contains( 'b', true, true )

Expected result

b element is returned.

Actual result

Method returns null.

Other details

Reproducible since CKEditor 4.0.
@mlewand mlewand added status:confirmed An issue confirmed by the development team. type:bug A bug. labels Jul 27, 2017
@mlewand mlewand mentioned this issue Jul 28, 2017
Merged
2 tasks
@mlewand mlewand added the good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. label Jul 28, 2017
@f1ames f1ames added this to the 4.7.2 milestone Jul 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. status:confirmed An issue confirmed by the development team. type:bug A bug.
Projects
None yet
Milestone
4.7.2
Development

No branches or pull requests
2 participants
@f1ames @mlewand