Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The table selector is truncated when in block quote #3322

Closed
jodator opened this issue Dec 3, 2018 · 4 comments
Closed

The table selector is truncated when in block quote #3322

jodator opened this issue Dec 3, 2018 · 4 comments
Assignees
Labels
package:block-quote type:bug This issue reports a buggy (incorrect) behavior.
Milestone

Comments

@jodator
Copy link
Contributor

jodator commented Dec 3, 2018

When table widget is inside blockquote the table's drag handler is truncated:

selection_084

Blockquote has hidden overflow and table has not big enough padding:

.ck-content blockquote {
    overflow: hidden;
}
@oleq
Copy link
Member

oleq commented Jan 14, 2019

I also think this is annoying. Let's see if we can do anything about that.

cc @dkonopka

@dkonopka
Copy link
Contributor

dkonopka commented Jan 15, 2019

It should be easy fix - just need to overwrite https://github.com/ckeditor/ckeditor5-table/blob/master/theme/table.css#L8 with:

.ck-content blockquote .table:first-child {
  margin-top: 2em;
}

Or we can do it with addding space equals to the selection handler height (works in Chrome, but I'm not sure if other browsers supports mixing em and px values in calc() ).

.ck-content blockquote .table:first-child {
  margin-top: calc( 1em + 16px );
}

@jodator
Copy link
Contributor Author

jodator commented Jan 15, 2019

but I'm not sure if other browsers supports mixing em and px

AFAIR this should work (I've used calc(100% - 6em) in CKFinder and that worked (AFAIR) so FF/IE8+ should be fine.

@dkonopka
Copy link
Contributor

dkonopka commented Jan 15, 2019

☝️ Percentages and em/px work fine it's true, but mixing px and em or other values it's another story, I'll check it out.

@dkonopka dkonopka self-assigned this Jan 15, 2019
oleq referenced this issue in ckeditor/ckeditor5-theme-lark Jan 17, 2019
Fix: The table selection handler should not be cropped when a table is a first-child of a blockquote or a root editable. Closes ckeditor/ckeditor5-block-quote#28.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-block-quote Oct 9, 2019
@mlewand mlewand added this to the iteration 22 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:bug This issue reports a buggy (incorrect) behavior. package:block-quote labels Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:block-quote type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants