Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable pasting and cutting when editor is readonly #2659

Closed
oskarwrobel opened this issue Jul 7, 2017 · 2 comments · Fixed by ckeditor/ckeditor5-clipboard#27
Closed

Disable pasting and cutting when editor is readonly #2659

oskarwrobel opened this issue Jul 7, 2017 · 2 comments · Fixed by ckeditor/ckeditor5-clipboard#27
Assignees
@oskarwrobel
Labels
package:clipboard type:improvement This issue reports a possible enhancement of an existing feature.
Milestone
iteration 11

Comments

@oskarwrobel
Copy link
Contributor

When the editor is in read-only mode pasting should be disabled.
It would be nice to use a command to handle pasting. Commands are disabled by default in read-only mode.
@Reinmar
Copy link
Member

Reinmar commented Jul 7, 2017

The idea for the paste command is that it could do everything the pasting does. There may be special features listening for certain paste events and that command should work in such a way to trigger them all. But the problem is that the data transfer facade is passed to those events so we'd need to mock it.

If you don't want to risk spending too much time on this now I'd recommend skipping the command.

@oskarwrobel oskarwrobel self-assigned this Jul 11, 2017
@oskarwrobel
Copy link
Contributor Author

The same issue is for cutting.

@oskarwrobel oskarwrobel changed the title Disable pasting when editor is readonly Disable clipboard when editor is readonly Jul 14, 2017
@oskarwrobel oskarwrobel changed the title Disable clipboard when editor is readonly Disable pasting and cutting when editor is readonly Jul 14, 2017
pjasiun referenced this issue in ckeditor/ckeditor5-clipboard Jul 18, 2017
Merge pull request #27 from ckeditor/t/26
0ba74d5 
Feature: Disable pasting and cutting when an editor is read-only. Closes #26.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-clipboard Oct 9, 2019
@mlewand mlewand added this to the iteration 11 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:improvement This issue reports a possible enhancement of an existing feature. package:clipboard labels Oct 9, 2019
@oskarwrobel oskarwrobel mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oskarwrobel oskarwrobel

Labels
package:clipboard type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Milestone
iteration 11
Development

Successfully merging a pull request may close this issue.

Disabled pasting and cutting when editor is read-only. ckeditor/ckeditor5-clipboard
3 participants
@Reinmar @oskarwrobel @mlewand