Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

view.Writer is missing in inputTransformation event #2674

Closed
scofalik opened this issue Mar 23, 2018 · 4 comments
Closed

view.Writer is missing in inputTransformation event #2674

scofalik opened this issue Mar 23, 2018 · 4 comments
Labels
package:clipboard resolution:expired This issue was closed due to lack of feedback. status:stale type:improvement This issue reports a possible enhancement of an existing feature.

Comments

@scofalik
Copy link
Contributor

At the moment the document fragment available in inputTransformation event callbacks is useless, because there's no convenient way to modify it. We are modifying model/view trees through model/view writers, unfortunately, view.Writer instance is not available inside inputTransformation callbacks.

My proposition is to make it available as another parameter (next to data) or as a parameter inside data object. We could use view.View#_writer but it is private. Or we can create a new view.Writer instance for clipboard pipeline.

@f1ames
Copy link
Contributor

f1ames commented Aug 17, 2018

Seems like new writer https://github.com/ckeditor/ckeditor5-engine/issues/1501 could be suitable for this.

@jodator
Copy link
Contributor

jodator commented Jan 14, 2019

@Reinmar I'd like to raise this issue. As we have this in the docs: https://github.com/ckeditor/ckeditor5-clipboard/blob/74c3c43085cb414696eafeddc31e354eeb3f0f1a/docs/framework/guides/deep-dive/clipboard.md#L70-L77

Which implies to import something from the engine aaaaand we tend to avoid it :) (#667, https://github.com/ckeditor/ckeditor5-engine/issues/1555, https://github.com/ckeditor/ckeditor5-engine/issues/1556).

I was to propose something similar as @scofalik proposed. Adding even a data.writer = new UpcastWriter() there will be sufficient.

ps.: I've stumbled upon this while doing PR review.

@mlewand mlewand transferred this issue from ckeditor/ckeditor5-clipboard Oct 9, 2019
@mlewand mlewand added this to the unknown milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:improvement This issue reports a possible enhancement of an existing feature. package:clipboard labels Oct 9, 2019
@pomek pomek removed this from the unknown milestone Feb 21, 2022
@CKEditorBot
Copy link
Collaborator

There has been no activity on this issue for the past year. We've marked it as stale and will close it in 30 days. We understand it may be relevant, so if you're interested in the solution, leave a comment or reaction under this issue.

@CKEditorBot
Copy link
Collaborator

We've closed your issue due to inactivity over the last year. We understand that the issue may still be relevant. If so, feel free to open a new one (and link this issue to it).

@CKEditorBot CKEditorBot added the resolution:expired This issue was closed due to lack of feedback. label Nov 2, 2023
@CKEditorBot CKEditorBot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:clipboard resolution:expired This issue was closed due to lack of feedback. status:stale type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Development

No branches or pull requests

6 participants