Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default theme #105

Closed
5 tasks
oleq opened this issue Jan 27, 2016 · 15 comments
Closed
5 tasks

Default theme #105

oleq opened this issue Jan 27, 2016 · 15 comments

Comments

@oleq
Copy link
Member

oleq commented Jan 27, 2016

Note: This is an umbrella issue, a heart of discussion around themes in CKE5. The aim is to avoid fragmentation and confusion about the mockups.

The architecture of themes is discussed in a separate issue.

Overview

CKEditor 5 needs a new, default theme.

  1. It must keep up with design trends.
  2. It must meet accessibility standards and requirements.
  3. It must reflect the flexibility, modularity and extensibility of the editor.
  4. It should be easy to integrate with web pages and applications, both visually and technically.

Problems to consider


Mockups

These mockups follow the Implementations document. This is the first attempt to take the ongoing UX discussion to the next level, an entry point to further discussion.

Classic interface

image

Tabbed interface

image

Menu

image

Dialogs

05-dialogs
06-dialogs

Inline editing

image

image

image

Fullpage

11-fullpage

@Reinmar
Copy link
Member

Reinmar commented Jan 27, 2016

What are the questions that we want to answer here? I mean – are we meant to discuss (spacing, colors, etc.) the designs already or sth else still?

@oleq
Copy link
Member Author

oleq commented Jan 27, 2016

@Reinmar See "Related issues" "The problems to consider" section.

@Reinmar
Copy link
Member

Reinmar commented Jan 27, 2016

OK, changing the title to "The problems to consider" makes this clear.

@oleq
Copy link
Member Author

oleq commented Jan 27, 2016

Yes, you were right. Also note that this is the beginning – there will be more problems in the future.

@koleary
Copy link

koleary commented Feb 18, 2016

Overall very nice.

Tabs could be even simpler, perhaps just heavy over or underline.

Dark title bar need not be so dark if tabs have no background. The lighter color can be the top bar background. It looks a bit heavy now.

My personal preference is larger and lighter weight for titles.

@georgephillips
Copy link

This looks like a big improvement. Have you considered moving the labels above the form fields. This would improve the usability and provide more space for UI elements.

Keep up the good work

@FinalAngel
Copy link

The tabbed interface looks great 👍

For the dialogs consider to use more wide space for the form elements, the more you see the better as @georgephillips also points out.

@oleq
Copy link
Member Author

oleq commented Feb 19, 2016

@georgephillips Good point, thanks!

@Reinmar
Copy link
Member

Reinmar commented May 25, 2016

I've been just reviewing the dropdown component and found the dropdown styling very confusing. It's so white in relation to totally unmarked buttons that they look like active all the time. I think that the styling should be very similar, if not identical.

See ckeditor/ckeditor5-theme-lark#12 (comment)

@oleq
Copy link
Member Author

oleq commented May 25, 2016

I don't think so, @Reinmar. It was a conscious design decision. Take a look on the interface of popular text processors like LibreOffice Writer or MS Word 2016. It's a common practice that dropdowns and other complex controls in the toolbar are slightly different than the rest of the interface.

@Reinmar
Copy link
Member

Reinmar commented May 25, 2016

Hm.. you're right. But:

  • I'm not sure whether this is necessary in case of a few buttons.
  • I think that you can type in those dropdowns in LO Writer and MS Word, so their white bg may be indicating that they are input fields. Different story. And this may even make our dropdown buttons more confusing.

But most importantly, it just looks odd when you have just couple of buttons. The below screenshot is of course an extreme situation when you have exactly three items and each of them is different. But we should take such case into consideration.

screen shot 2016-05-25 at 16 53 47

(of course margins are missing and the dropdown button is too big due to the border, but this is a different story)

@Reinmar
Copy link
Member

Reinmar commented May 25, 2016

BTW when I look at designs like this https://twitter.com/steipete/status/735377624265072641 I start to think that perhaps we should adopt a single convention and follow it closely. I think that perhaps we've been trying to be too innovative. For many aspects that makes sense, and the UX in some sense will be one of them, but design not necessarily.

@luzfcb
Copy link

luzfcb commented May 25, 2016

sorry if this is the wrong place to ask:

since html has no implements a concept of physical page (A4 paper), ckeditor 5 will provide anything that helps to implement the editor with concept of physical page, like google docs, ms office online do?

@Reinmar
Copy link
Member

Reinmar commented May 25, 2016

Thanks for asking. That's a topic for a separate ticket: #147

@Reinmar
Copy link
Member

Reinmar commented Apr 20, 2018

Cleaning up old discussions. See #186.

@Reinmar Reinmar closed this as completed Apr 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants