Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Umbrella] Engine refactoring #4107

Closed
6 tasks done
pjasiun opened this issue Jul 11, 2017 · 4 comments
Closed
6 tasks done

[Umbrella] Engine refactoring #4107

pjasiun opened this issue Jul 11, 2017 · 4 comments

Comments

@pjasiun
Copy link

pjasiun commented Jul 11, 2017

Topics to be considered:

@pjasiun pjasiun changed the title Engine refactoring (umbrella ticket) Engine model refactoring (umbrella ticket) Jul 11, 2017
@scofalik
Copy link
Contributor

We were talking about making conversion on changesDone event. I can't find exact issue or even if we finally all agreed this is a good idea. Here is the issue I found: https://github.com/ckeditor/ckeditor5-engine/issues/829

@Reinmar
Copy link
Member

Reinmar commented Jul 11, 2017

I also think that https://github.com/ckeditor/ckeditor5-engine/issues/897 (stop cloning everything, enforced immutability) is a part of this.

@Reinmar
Copy link
Member

Reinmar commented Sep 12, 2017

I'll add https://github.com/ckeditor/ckeditor5-engine/issues/1038 cause it grew to a significant problem and it turns out that it's not a quick and invisible change too (@scofalik can tell you more).

@ckeditor ckeditor deleted a comment from pjasiun Oct 10, 2017
@Reinmar Reinmar changed the title Engine model refactoring (umbrella ticket) Engine refactoring (umbrella ticket) Oct 15, 2017
@Reinmar Reinmar changed the title Engine refactoring (umbrella ticket) [Umberlla] Engine refactoring Oct 15, 2017
@Reinmar Reinmar changed the title [Umberlla] Engine refactoring [Umbrella] Engine refactoring Oct 20, 2017
@pjasiun
Copy link
Author

pjasiun commented Mar 9, 2018

Finally!

@pjasiun pjasiun closed this as completed Mar 9, 2018
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-engine Oct 9, 2019
@mlewand mlewand added this to the iteration 14 milestone Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants