Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues caused by attributes with undefined values #4111

Closed
Reinmar opened this issue Jul 13, 2017 · 2 comments
Closed

Issues caused by attributes with undefined values #4111

Reinmar opened this issue Jul 13, 2017 · 2 comments
Labels
package:engine resolution:wontfix This issue will not be fixed because the team decided that for given reasons it does not make sense. status:discussion type:improvement This issue reports a possible enhancement of an existing feature.

Comments

@Reinmar
Copy link
Member

Reinmar commented Jul 13, 2017

#500 showed that it may happen that a slightly broken converter will try to create an element in the model which has some attribute but the value of this attribute is undefined.

There's a range of issues which such attributes may cause. It can't be stringified (JSON.stringify() will skip it) so it may blow up collaborative editing servers. It causes issues on conversion to the view because (that's my hypothesis) proper attribute elements are created but they are not merged later on for some reasons (the second part of #500).

I wonder if we shouldn't reject such attributes at some point because such issues may be hard to track. Perhaps, once will have "one API to rule them all", the right place will be in the model writer? Or perhaps this should be done directly in Node?

@Reinmar
Copy link
Member Author

Reinmar commented Jul 13, 2017

Another thing is that we could actually define what kind of falsy values the model handles. I think that null, 0, '' and false work fine. It'd be good to have some policy about that.

@Reinmar
Copy link
Member Author

Reinmar commented Aug 8, 2019

This problem isn't hitting back, so let's assume it does not exist.

@Reinmar Reinmar closed this as completed Aug 8, 2019
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-engine Oct 9, 2019
@mlewand mlewand added module:model resolution:wontfix This issue will not be fixed because the team decided that for given reasons it does not make sense. status:discussion type:improvement This issue reports a possible enhancement of an existing feature. package:engine labels Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:engine resolution:wontfix This issue will not be fixed because the team decided that for given reasons it does not make sense. status:discussion type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Development

No branches or pull requests

2 participants