Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tests] Warnings are logged after recent changes #4447

Closed
Reinmar opened this issue Dec 3, 2018 · 2 comments · Fixed by ckeditor/ckeditor5-engine#1602
Closed

[Tests] Warnings are logged after recent changes #4447

Reinmar opened this issue Dec 3, 2018 · 2 comments · Fixed by ckeditor/ckeditor5-engine#1602
Assignees
@f1ames
Labels
package:engine type:task This issue reports a chore (non-production change) and other types of "todos".
Milestone
iteration 22

Comments

@Reinmar
Copy link
Member

Reinmar commented Dec 3, 2018

Warnings are logged in the tests after recent changes:

Safari 11.1.2 (Mac OS X 10.13.6) WARN: 'conversion-attribute-to-attribute-on-text: Trying to convert text node's attribute with attribute-to-attribute converter. Read more: https://ckeditor.com/docs/ckeditor5/latest/framework/guides/support/error-codes.html#error-conversion-attribute-to-attribute-on-text
', undefined
Safari 11.1.2 (Mac OS X 10.13.6) WARN: 'conversion-attribute-to-attribute-on-text: Trying to convert text node's attribute with attribute-to-attribute converter. Read more: https://ckeditor.com/docs/ckeditor5/latest/framework/guides/support/error-codes.html#error-conversion-attribute-to-attribute-on-text
', undefined

It started with ckeditor/ckeditor5-engine@6659582

cc @f1ames @scofalik
@f1ames
Copy link
Contributor

f1ames commented Dec 3, 2018

@Reinmar These warnings are logged by the unit test which checks the incorrect flow (which logs a warning). I assume we should stub log.warn() to not print anything in the console in those tests?

@Reinmar
Copy link
Member Author

Reinmar commented Dec 3, 2018

Yes. We usually stub log's methods to mute it.

jodator referenced this issue in ckeditor/ckeditor5-engine Jan 4, 2019
@jodator
Merge pull request #1602 from ckeditor/t/1601
1d15dad 
Tests: Stub `log.warn` to not print anything during test run. Closes #1601.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-engine Oct 9, 2019
@mlewand mlewand added this to the iteration 22 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:task This issue reports a chore (non-production change) and other types of "todos". package:engine labels Oct 9, 2019
@f1ames f1ames mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@f1ames f1ames

Labels
package:engine type:task This issue reports a chore (non-production change) and other types of "todos".
Projects
None yet
Milestone
iteration 22
Development

Successfully merging a pull request may close this issue.

Tests: Stub log.warn to not print anything during test run ckeditor/ckeditor5-engine
3 participants
@Reinmar @f1ames @mlewand