Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance check #3767

Closed
pjasiun opened this issue Jun 17, 2016 · 9 comments
Closed

Performance check #3767

pjasiun opened this issue Jun 17, 2016 · 9 comments
Labels
package:engine resolution:expired This issue was closed due to lack of feedback. status:stale type:improvement This issue reports a possible enhancement of an existing feature. type:task This issue reports a chore (non-production change) and other types of "todos".

Comments

@pjasiun
Copy link

pjasiun commented Jun 17, 2016

We did check the performance at the very beginning (ckeditor/ckeditor5-design#65), but since then engine architecture changes a lot. We need to check it again. There are multiple aspects to be tests:

  • memory usage - we need to know how big document we can handle, how much memory "standard" document use,
  • conversion time - we should add more converters and check how much time it takes to load a big and complex document,
  • initialisation time - now it takes a lot of time because of 400-500 modules which need to be loaded, we should check it with a bundled version.
@Reinmar
Copy link
Member

Reinmar commented Nov 26, 2018

Performance issue reported in #1374.

@Reinmar
Copy link
Member

Reinmar commented Nov 26, 2018

Another performance issue report (FF only): #1377

@oleq
Copy link
Member

oleq commented Dec 18, 2018

Another one: #1398

@ckotzbauer
Copy link

@oleq @Reinmar
Are there any plans when these issues (especially the loading and conversion time problems) can be addressed? This has a huge impact to some of our customers. If these issues stay for longer we have to consider some architectural changes in our own application for the integration of CK.

@Reinmar
Copy link
Member

Reinmar commented Jan 8, 2019

Actually, we've been doing a bit of research recently because we noticed that the diff() function that we use to compare list of nodes during rendering is causing slowdowns more often than we thought.

I checked whether your scenario reported in #1398 falls into this category and it looks like it is.

Fortunately, we plan to improve the diff() function (by adding fast paths for some troublesome cases). There's big chance that it will solve your problem, although, it's hard now to tell whether it's the only problem.

@Reinmar
Copy link
Member

Reinmar commented Feb 13, 2019

We closed https://github.com/ckeditor/ckeditor5-utils/issues/269 today and there are huge improvements :) Renderer calls which now take less than 200ms took 10s+ before this change.

Those changes will be released in ~2-3 weeks.

@mlewand mlewand transferred this issue from ckeditor/ckeditor5-engine Oct 9, 2019
@mlewand mlewand added this to the backlog milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:improvement This issue reports a possible enhancement of an existing feature. type:task This issue reports a chore (non-production change) and other types of "todos". package:engine labels Oct 9, 2019
@Reinmar
Copy link
Member

Reinmar commented Nov 28, 2019

I pushed some data for testing two scenarios:

Branch: https://github.com/ckeditor/ckeditor5/compare/i/3767

@CKEditorBot
Copy link
Collaborator

There has been no activity on this issue for the past year. We've marked it as stale and will close it in 30 days. We understand it may be relevant, so if you're interested in the solution, leave a comment or reaction under this issue.

@CKEditorBot
Copy link
Collaborator

We've closed your issue due to inactivity over the last year. We understand that the issue may still be relevant. If so, feel free to open a new one (and link this issue to it).

@CKEditorBot CKEditorBot added the resolution:expired This issue was closed due to lack of feedback. label Nov 2, 2023
@CKEditorBot CKEditorBot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:engine resolution:expired This issue was closed due to lack of feedback. status:stale type:improvement This issue reports a possible enhancement of an existing feature. type:task This issue reports a chore (non-production change) and other types of "todos".
Projects
None yet
Development

No branches or pull requests

7 participants