Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LiveSelection.setAttributes() enqueues its changes #3813

Closed
Reinmar opened this issue Sep 12, 2016 · 1 comment
Closed

LiveSelection.setAttributes() enqueues its changes #3813

Reinmar opened this issue Sep 12, 2016 · 1 comment
Assignees
Labels
package:engine type:bug This issue reports a buggy (incorrect) behavior.
Milestone

Comments

@Reinmar
Copy link
Member

Reinmar commented Sep 12, 2016

This shouldn't be done automatically, because when you use setAttributes() you need to enq changes anyway. So we double the enque. See also https://github.com/ckeditor/ckeditor5-core/issues/18.

@Reinmar
Copy link
Member Author

Reinmar commented Oct 18, 2016

Fixed by ckeditor/ckeditor5-engine#634.

@Reinmar Reinmar closed this as completed Oct 18, 2016
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-engine Oct 9, 2019
@mlewand mlewand added this to the iteration 4 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:bug This issue reports a buggy (incorrect) behavior. package:engine labels Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:engine type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Development

No branches or pull requests

3 participants