model.Document#lastBatch

[scofalik]

When creating fixer for paragraph feature I stumbled upon a problem with batch type.

The fixer is a callback for changesDone event, that creates a <paragraph> element, if there are no contents in given root. This prevents having empty roots.

However the question is what should be a batch type in this case?

If it is not transparent then the batch will create undo step. If it is transparent then it can't be undone, meaning that the create <p> will stay at its place when user starts undoing.

The first option is better but neither is good. I can imagine that there might be more places where we might want glue some deltas to the last batch so they are reverted together.

On the other hand, when I think of it now, the batches are available on change event, so maybe the fixer for paragraph should listen to change event?

[pjasiun]

I rencenty also met the problem that I can not access batch in the conversion and decided to add change listener instead.

But note that I also proposed to have last batch as a documents property here: https://github.com/ckeditor/ckeditor5-engine/issues/858#issuecomment-284701045.

[scofalik]

I knew I read it somewhere ;)

[Reinmar]

Worth reading: https://github.com/ckeditor/ckeditor5-paragraph/issues/19#issuecomment-297669109.

[Reinmar]

Is it still a problem, @scofalik?

[CKEditorBot]

There has been no activity on this issue for the past two years. We've marked it as stale and will close it in 30 days. We understand it may be relevant, so if you're interested in the solution, leave a comment or reaction under this issue.

[CKEditorBot]

We've closed your issue due to inactivity over the last year. We understand that the issue may still be relevant. If so, feel free to open a new one (and link this issue to it).