Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A couple of tests fail on Chrome 58 #4051

Closed
Reinmar opened this issue Apr 20, 2017 · 4 comments · Fixed by ckeditor/ckeditor5-engine#926
Closed

A couple of tests fail on Chrome 58 #4051

Reinmar opened this issue Apr 20, 2017 · 4 comments · Fixed by ckeditor/ckeditor5-engine#926
Assignees
@Reinmar
Labels
package:engine type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 10

Comments

@Reinmar
Copy link
Member

Reinmar commented Apr 20, 2017

Chrome 58.0.3029 (Mac OS X 10.12.4)

A couple of tests fail locally and on Travis.
@Reinmar Reinmar changed the title Couple of tests fail on Chrome 58 A couple of tests fail on Chrome 58 Apr 20, 2017
@szymonkups szymonkups self-assigned this Apr 20, 2017
Reinmar referenced this issue in ckeditor/ckeditor5-engine Apr 20, 2017
@Reinmar
Internal: Fixed a test and simplified jumpOverInlineFiller() implemen…
e1fc5e0 
…tation. See #925.
@Reinmar
Copy link
Member Author

Reinmar commented Apr 20, 2017 •
edited
Loading

I fixed one of the tests in ckeditor/ckeditor5-engine@e1fc5e0 (on master).

@Reinmar
Copy link
Member Author

Reinmar commented Apr 20, 2017

Also, the fake selection tests which fail, fail also on Edge and Firefox now. So Chrome's behaviour was in some way aligned to these browsers.

@Reinmar
Copy link
Member Author

Reinmar commented Apr 20, 2017

OK, I'll handle most of this in the #4049. It's hard to split the work anyway because it'd be nice to verify the changes made for this ticket (#925) on Edge and it's only possible on t/923.

@Reinmar Reinmar assigned Reinmar and unassigned szymonkups Apr 20, 2017
@Reinmar
Copy link
Member Author

Reinmar commented Apr 20, 2017

OK, all's clear on t/923. I only needed to align tests. Chrome, apparently, stopped normalising anchorNode/Offset and focusNode/Offset, so only Safari needs this now.

Reinmar referenced this issue in ckeditor/ckeditor5-engine Apr 24, 2017
@Reinmar
Fix: Improved compatibility with MS Edge. See #923. Closes #925.
1af4a50
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-engine Oct 9, 2019
@mlewand mlewand added this to the iteration 10 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:bug This issue reports a buggy (incorrect) behavior. package:engine labels Oct 9, 2019
@Reinmar Reinmar mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Reinmar Reinmar

Labels
package:engine type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 10
Development

Successfully merging a pull request may close this issue.

Various test improvements and compatibility issues ckeditor/ckeditor5-engine
3 participants
@Reinmar @szymonkups @mlewand