Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial image feature implementation #5028

Closed
szymonkups opened this issue Oct 10, 2016 · 1 comment · Fixed by ckeditor/ckeditor5-image#7
Closed

Initial image feature implementation #5028

szymonkups opened this issue Oct 10, 2016 · 1 comment · Fixed by ckeditor/ckeditor5-image#7
Assignees
Milestone

Comments

@szymonkups
Copy link
Contributor

Implementation should follow Editor Recommendations: Image.
Image will be the first widget-based feature, and should be a reference implementation for other widget features to follow.
Topics connected with Image feature and widgets:

  • fake selection - discussed here https://github.com/ckeditor/ckeditor5-engine/issues/627,
  • D&D - image and other widgets should be draggable,
  • nested editables should be supported (to implement for example image caption),
  • things like captioning and alignment should be easily reusable in other widgets implementations.

UX and UI of image feature will be discussed later on.

@szymonkups szymonkups self-assigned this Oct 10, 2016
@szymonkups
Copy link
Contributor Author

I've created PR ckeditor/ckeditor5-image#7. It includes very basic image support (see PR description). Further implementation will be done in separate issues that will address things described in previous comment:

  • D&D - image and other widgets should be draggable,
  • nested editables should be supported (to implement for example image caption),
  • things like captioning and alignment should be easily reusable in other widgets implementations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants