Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial image feature implementation #1

Closed
szymonkups opened this Issue Oct 10, 2016 · 1 comment

Comments

Projects
None yet
3 participants
@szymonkups
Copy link
Contributor

szymonkups commented Oct 10, 2016

Implementation should follow Editor Recommendations: Image.
Image will be the first widget-based feature, and should be a reference implementation for other widget features to follow.
Topics connected with Image feature and widgets:

  • fake selection - discussed here ckeditor/ckeditor5-engine#627,
  • D&D - image and other widgets should be draggable,
  • nested editables should be supported (to implement for example image caption),
  • things like captioning and alignment should be easily reusable in other widgets implementations.

UX and UI of image feature will be discussed later on.

@szymonkups

This comment has been minimized.

Copy link
Contributor Author

szymonkups commented Nov 14, 2016

I've created PR #7. It includes very basic image support (see PR description). Further implementation will be done in separate issues that will address things described in previous comment:

  • D&D - image and other widgets should be draggable,
  • nested editables should be supported (to implement for example image caption),
  • things like captioning and alignment should be easily reusable in other widgets implementations.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.