Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The image must extend $block #5063

Closed
Reinmar opened this issue Feb 19, 2017 · 6 comments
Closed

The image must extend $block #5063

Reinmar opened this issue Feb 19, 2017 · 6 comments
Labels
package:image type:improvement This issue reports a possible enhancement of an existing feature.

Comments

@Reinmar
Copy link
Member

Reinmar commented Feb 19, 2017

As explained in https://github.com/ckeditor/ckeditor5-engine/issues/532#issuecomment-280919795.

It's a part of bigger refactoring which we need to make.

@scofalik
Copy link
Contributor

I wonder whether we should re-think what kind of abstract definitions we have in schema. Maybe having $block is just incorrect?

@Reinmar
Copy link
Member Author

Reinmar commented Feb 20, 2017

That's still open for me too. But I don't think that "block" is that bad. Image is a block element after all. It's just not a text container.

@Reinmar
Copy link
Member Author

Reinmar commented Mar 28, 2017

Handling block images correctly will require https://github.com/ckeditor/ckeditor5-engine/issues/894.

@Reinmar
Copy link
Member Author

Reinmar commented Apr 6, 2017

Once we'll make image a block, we also need to check if it's correctly handled in some merging scenarios on Backspace. E.g. ckeditor/ckeditor5-engine#907 (comment)

@Reinmar
Copy link
Member Author

Reinmar commented May 4, 2017

We made caption inheriting from blocks in https://github.com/ckeditor/ckeditor5-image/pull/95/files which introduced https://github.com/ckeditor/ckeditor5-block-quote/issues/10 ;<.

@Reinmar
Copy link
Member Author

Reinmar commented Apr 5, 2018

This was fixed once we refactored the schema. The $block element was detached from the isBlock property. Now, the image can have isBlock, be "allowed where $block is", but it's also isObject so it's filtered out properly by e.g. the list feature.

@Reinmar Reinmar closed this as completed Apr 5, 2018
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-image Oct 9, 2019
@mlewand mlewand added resolution:solved type:improvement This issue reports a possible enhancement of an existing feature. package:image labels Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:image type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Development

No branches or pull requests

3 participants