Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link converter should not pick up <a> without href #4802

Closed
Reinmar opened this issue Jul 13, 2017 · 0 comments · Fixed by ckeditor/ckeditor5-link#140
Closed

Link converter should not pick up <a> without href #4802

Reinmar opened this issue Jul 13, 2017 · 0 comments · Fixed by ckeditor/ckeditor5-link#140
Assignees
@Reinmar
Labels
package:link type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 11

Comments

@Reinmar
Copy link
Member

Reinmar commented Jul 13, 2017

Part of #500.
@Reinmar Reinmar self-assigned this Jul 13, 2017
oleq referenced this issue in ckeditor/ckeditor5-link Jul 14, 2017
@oleq
Merge pull request #140 from ckeditor/t/139
80e4c03 
Fix: `<a>` elements without the `href` attribute should not be picked up by the converter when loading data or pasting. Closes #139.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-link Oct 9, 2019
@mlewand mlewand added this to the iteration 11 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:bug This issue reports a buggy (incorrect) behavior. package:link labels Oct 9, 2019
@Reinmar Reinmar mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Reinmar Reinmar

Labels
package:link type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 11
Development

Successfully merging a pull request may close this issue.

Improved the converter to check the href attr ckeditor/ckeditor5-link
2 participants
@Reinmar @mlewand