Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider implementing synchronisation link text → href when typing #4724

Closed
oleq opened this issue Aug 24, 2016 · 3 comments
Closed

Consider implementing synchronisation link text → href when typing #4724

oleq opened this issue Aug 24, 2016 · 3 comments
Labels
domain:ui/ux This issue reports a problem related to UI or UX. package:link resolution:expired This issue was closed due to lack of feedback. status:stale type:feature This issue reports a feature request (an idea for a new functionality or a missing option). type:question This issue asks a question (how to...).

Comments

@oleq
Copy link
Member

oleq commented Aug 24, 2016

A followup of https://github.com/ckeditor/ckeditor5-link/issues/2#issuecomment-240374891.

If you have a link which href equals text, update its href when its text is changed.


Similarly to https://github.com/ckeditor/ckeditor5-link/issues/9, where if link href === innerHTML, any change to href should update innerHTML

image

the whole thing could also work the other way round, which is when a text (innerHTML) of a valid link is edited by the user, the link href is also updated:

image

Pros

  • It shows you the world of magic and never-ending joy.
  • It's super–fast.

Cons

@oleq oleq changed the title Consider implementing synchronisation link text → href Consider implementing synchronisation link text → href when typing Aug 24, 2016
@DarthVictor
Copy link

DarthVictor commented Apr 5, 2018

Hello. Is there any chance that this feature would be implemented? I tried to implement it myself, but I had a lot of issues with changing link text while editting, with link detection and so on.

@mlewand mlewand transferred this issue from ckeditor/ckeditor5-link Oct 9, 2019
@mlewand mlewand added this to the unknown milestone Oct 9, 2019
@mlewand mlewand added domain:ui/ux This issue reports a problem related to UI or UX. module:ux type:feature This issue reports a feature request (an idea for a new functionality or a missing option). type:question This issue asks a question (how to...). package:link labels Oct 9, 2019
@Reinmar Reinmar removed the module:ux label Jan 15, 2020
@pomek pomek removed this from the unknown milestone Feb 21, 2022
@CKEditorBot
Copy link
Collaborator

There has been no activity on this issue for the past year. We've marked it as stale and will close it in 30 days. We understand it may be relevant, so if you're interested in the solution, leave a comment or reaction under this issue.

@CKEditorBot
Copy link
Collaborator

We've closed your issue due to inactivity over the last year. We understand that the issue may still be relevant. If so, feel free to open a new one (and link this issue to it).

@CKEditorBot CKEditorBot added the resolution:expired This issue was closed due to lack of feedback. label Nov 2, 2023
@CKEditorBot CKEditorBot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:ui/ux This issue reports a problem related to UI or UX. package:link resolution:expired This issue was closed due to lack of feedback. status:stale type:feature This issue reports a feature request (an idea for a new functionality or a missing option). type:question This issue asks a question (how to...).
Projects
None yet
Development

No branches or pull requests

6 participants