Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Safari] Link balloon is shown outside the view in manual tests if selection is collapsed #4748

Closed
maxbarnas opened this issue Sep 30, 2016 · 11 comments
Assignees
Labels
package:link type:bug This issue reports a buggy (incorrect) behavior.
Milestone

Comments

@maxbarnas
Copy link
Contributor

Test: http://localhost:1030/build/modules/amd/tests/link/manual/link.

When I click on the first word in editor, the link balloon is shown as below:
Screen Shot 2016-09-30 at 14.03.10.png

@maxbarnas maxbarnas changed the title [Safari] Link ballon is shown outside the view in manual tests [Safari] Link balloon is shown outside the view in manual tests Sep 30, 2016
@pomek
Copy link
Member

pomek commented Sep 30, 2016

It can be also reproduced in Chrome.

@maxbarnas
Copy link
Contributor Author

@pomek I'll update the title.

@maxbarnas maxbarnas changed the title [Safari] Link balloon is shown outside the view in manual tests [Safari, Chrome] Link balloon is shown outside the view in manual tests Sep 30, 2016
@oskarwrobel
Copy link
Contributor

Looks like a problem with getting offset of collapsed selection.
I can't reproduce it on Chrome.

@maxbarnas
Copy link
Contributor Author

@oskarwrobel Yep, I can't reproduce it either. @pomek, can you provide steps to reproduce it, along with version of Chrome, type of screen (retina, non-retina), zoom factor, and all that stuff?

@pomek
Copy link
Member

pomek commented Sep 30, 2016

Eh. Yesterday I could reproduce it. Today I cannot. Maybe it was Firefox instead of Chrome. I am not sure. I would like to apologize for the mess.

@maxbarnas maxbarnas changed the title [Safari, Chrome] Link balloon is shown outside the view in manual tests [Safari] Link balloon is shown outside the view in manual tests Sep 30, 2016
@Reinmar
Copy link
Member

Reinmar commented Sep 30, 2016

There's a ticket on review which fixes some cases in positioning – maybe that it will fix this issue.

@oskarwrobel
Copy link
Contributor

There's a ticket on review which fixes some cases in positioning – maybe that it will fix this issue.

I'm afraid it is a different issue.

@Reinmar
Copy link
Member

Reinmar commented Sep 30, 2016

Right... empty selection. I remember dealing with this in the past. It wasn't easy – I had to extend the range in some direction – otherwise the box was calculated incorrectly. And there were edge cases like empty blocks where the position had to be taken from the element.

@oskarwrobel
Copy link
Contributor

oskarwrobel commented Sep 30, 2016

Here is a fix for this: ckeditor/ckeditor5-ui-default#91

@Reinmar Reinmar changed the title [Safari] Link balloon is shown outside the view in manual tests [Safari] Link balloon is shown outside the view in manual tests if selection is collapsed Oct 5, 2016
@Reinmar
Copy link
Member

Reinmar commented May 3, 2017

Still as much reproducible as in the past. Could we fix it by positioning to the entire block if 0,0 cords were returned?

A full fix would be to inject an empty element inline in the place of the caret and positioning according to it. This may be required later on when we'll deal with scrolling to the caret on Enter, Delete, etc. but this is much more work.

@oleq oleq self-assigned this May 4, 2017
@oleq
Copy link
Member

oleq commented May 4, 2017

ckeditor/ckeditor5-utils#154 should fix the issue.

@Reinmar Reinmar closed this as completed May 4, 2017
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-link Oct 9, 2019
@mlewand mlewand added this to the iteration 10 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:bug This issue reports a buggy (incorrect) behavior. package:link labels Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:link type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Development

No branches or pull requests

6 participants