Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pasted list indentation is not adjusted to the paste position #2978

Closed
Reinmar opened this issue Mar 29, 2017 · 1 comment · Fixed by ckeditor/ckeditor5-list#59
Closed

Pasted list indentation is not adjusted to the paste position #2978

Reinmar opened this issue Mar 29, 2017 · 1 comment · Fixed by ckeditor/ckeditor5-list#59
Assignees
Labels
package:list type:bug This issue reports a buggy (incorrect) behavior.
Milestone

Comments

@Reinmar
Copy link
Member

Reinmar commented Mar 29, 2017

Copy:

image

Paste here:

image

Result:

image

Expected something like:

image

@Reinmar
Copy link
Member Author

Reinmar commented Mar 29, 2017

The problem here is that the pasted list items have indents 0, 1, 2. The first one gets merged into the list item in which we paste, the second one keeps its indent=1 which creates and outdented list, instead of nested list, under "NumbrereBullet list item 1".

The solution here may be to process the content on DataController#insertContent. All list items at the beginning of the data fragment should have indents increased by the indentation of the item to which you're pasting.

This should be fairly simple. However, I'm not sure that it's gonna help with all situations.

@scofalik scofalik self-assigned this Apr 14, 2017
Reinmar referenced this issue in ckeditor/ckeditor5-list Apr 19, 2017
Fix: Pasted list items' indentation now will be correctly adjusted if they are pasted into a nested list. Closes #56.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-list Oct 9, 2019
@mlewand mlewand added this to the iteration 10 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:bug This issue reports a buggy (incorrect) behavior. package:list labels Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:list type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants