Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use smarter position of the insertion #2739

Closed
oleq opened this issue Aug 22, 2018 · 2 comments · Fixed by ckeditor/ckeditor5-media-embed#34
Closed

Use smarter position of the insertion #2739

oleq opened this issue Aug 22, 2018 · 2 comments · Fixed by ckeditor/ckeditor5-media-embed#34
Assignees
Labels
package:media-embed type:improvement This issue reports a possible enhancement of an existing feature.
Milestone

Comments

@oleq
Copy link
Member

oleq commented Aug 22, 2018

The media widget is inserted always after the block in which you currently have the caret. The image insertion works a bit better and if you have the caret at the beginning of that block it gets inserter before it. This can be a followup, of course.

A follow-up of ckeditor/ckeditor5-media-embed#2 (comment).

@pjasiun
Copy link

pjasiun commented Sep 10, 2018

Similarly to my comments in the table feature (https://github.com/ckeditor/ckeditor5-table/issues/27#issuecomment-419917100 and https://github.com/ckeditor/ckeditor5-table/issues/27#issuecomment-419917623), it looks very inconsistent in Letters now.

Especially:

  • when the position is at the beginning of the block, it should be inserted before the block,
  • when the position is in the empty block it should be inserted instead of block.

This is now it looks like now:
insert-before-after

insert-empty

@Reinmar
Copy link
Member

Reinmar commented Sep 11, 2018

Let's continue this discussion in #1243.

@jodator jodator self-assigned this Sep 13, 2018
pjasiun referenced this issue in ckeditor/ckeditor5-media-embed Sep 18, 2018
Internal: Media embed should insert media object the same way as other widgets. Closes #12.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-media-embed Oct 9, 2019
@mlewand mlewand added this to the iteration 20 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:improvement This issue reports a possible enhancement of an existing feature. package:media-embed labels Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:media-embed type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants