Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Up/down arrows are locked #4637

Closed
Reinmar opened this issue Apr 3, 2019 · 2 comments · Fixed by ckeditor/ckeditor5-mention#51
Closed

Up/down arrows are locked #4637

Reinmar opened this issue Apr 3, 2019 · 2 comments · Fixed by ckeditor/ckeditor5-mention#51
Assignees
Labels
package:mention type:bug This issue reports a buggy (incorrect) behavior.
Milestone

Comments

@Reinmar
Copy link
Member

Reinmar commented Apr 3, 2019

I recorded pressing:

  • right (moves caret),
  • left (moves caret),
  • top/bottom (irreversibly changes item selection, locks the caret).

Apr-03-2019 11-25-21

I don't think that up/down should be locked. But if you think it should, then at least the item selection should not be changed (if there's just one item).

@jodator
Copy link
Contributor

jodator commented Apr 3, 2019

I think that's a minor bug in selection cycling - the item is unselected but should not. You still can move caret and execute selected (even if not visually) item. Should be easy fix.

@Reinmar
Copy link
Member Author

Reinmar commented Apr 3, 2019

I just realised that we must be locking the up/down arrows because they are normally used to navigate in this panel :D That didn't occur to me initially.

So, yeah, let's fix selection cycling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:mention type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants