Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce ParagraphButtonUI #3307

Closed
szymonkups opened this issue Apr 6, 2018 · 6 comments · Fixed by ckeditor/ckeditor5-paragraph#34
Closed

Introduce ParagraphButtonUI #3307

szymonkups opened this issue Apr 6, 2018 · 6 comments · Fixed by ckeditor/ckeditor5-paragraph#34
Assignees
Labels
package:paragraph type:feature This issue reports a feature request (an idea for a new functionality or a missing option).
Milestone

Comments

@szymonkups
Copy link
Contributor

ParagraphButtonUI should be created, similar to: https://github.com/ckeditor/ckeditor5-heading/issues/104, with the default icon for the paragraph. Plugin should be optional, not required by Paragaph plugin.

@szymonkups szymonkups self-assigned this Apr 6, 2018
@ma2ciek
Copy link
Contributor

ma2ciek commented Apr 6, 2018

We had a F2F talk about providing translations for the plugin. Both ckeditor5-heading and ckeditor5-paragraph packages should use paragraph, so the paragraph msgid should be moved to the ckeditor5-core. (ckeditor5-core is the core package for translations and should be used to prevent duplications). But removing the paragraph msgid from ckeditor5-heading will cause removing all translations for paragraph.

This case has already popped out and its ticket is waiting for the PR: https://github.com/ckeditor/ckeditor5-dev/issues/376.

@Reinmar
Copy link
Member

Reinmar commented Apr 6, 2018

Can we use the translation available in the heading package for now? Or is the scope limited to each package + core?

@ma2ciek
Copy link
Contributor

ma2ciek commented Apr 6, 2018

@Reinmar
Copy link
Member

Reinmar commented Apr 6, 2018

But it's about repeated context. And is the paragraph feature able to use the translation from the heading feature? Or does that fall into the "repeated context" check?

@Reinmar
Copy link
Member

Reinmar commented Apr 6, 2018

BTW, I may avoid using translations:collect for a while, until we figure out ckeditor/ckeditor5-dev#376. So, for now, it's just a question of whether it's going to build :D

@ma2ciek
Copy link
Contributor

ma2ciek commented Apr 6, 2018

It should build, translations are stored in the key -> translation object for now.

pjasiun referenced this issue in ckeditor/ckeditor5-paragraph Apr 10, 2018
Feature: Introduced ParagraphButtonUI plugin. Closes #33.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-paragraph Oct 9, 2019
@mlewand mlewand added this to the iteration 16 milestone Oct 9, 2019
@mlewand mlewand added type:feature This issue reports a feature request (an idea for a new functionality or a missing option). package:paragraph labels Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:paragraph type:feature This issue reports a feature request (an idea for a new functionality or a missing option).
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants