Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add images (nested widgets) support in tables. #3221

Closed
jodator opened this issue Aug 7, 2018 · 6 comments · Fixed by ckeditor/ckeditor5-table#155
Closed

Add images (nested widgets) support in tables. #3221

jodator opened this issue Aug 7, 2018 · 6 comments · Fixed by ckeditor/ckeditor5-table#155
Assignees
Labels
package:table type:feature This issue reports a feature request (an idea for a new functionality or a missing option).
Milestone

Comments

@jodator
Copy link
Contributor

jodator commented Aug 7, 2018

Follow-up for the #3199 - currently there are some issues with widget in widget (images in tables):

  • click select does not work
  • ballon toolbar sometimes does not work
  • pasted image behaves differently then converted from data - you can edit caption only for pasted
  • fake selection sometimes is broken
@jodator jodator self-assigned this Aug 7, 2018
@Reinmar
Copy link
Member

Reinmar commented Sep 4, 2018

I guess that images are now allowed (by the schema) in tables. Am I right? So the iteration 20 won't be complete unless we close this ticket or disallow images in tables?

@Reinmar
Copy link
Member

Reinmar commented Sep 4, 2018

I'm asking because we need to do either A or B.

@jodator
Copy link
Contributor Author

jodator commented Sep 4, 2018

I guess that images are now allowed (by the schema) in tables. Am I right? So the iteration 20 won't be complete unless we close this ticket or disallow images in tables?

You're guess is incorrect ;) I've disabled it in the ckeditor/ckeditor5-table#97 PR:
https://github.com/ckeditor/ckeditor5-table/blob/bd5b81d0062cc984d08f6ea456108ede632b7b89/src/tableediting.js#L84-L89

I've disable it after issues with widget in widget (image in table): #3219, ckeditor/ckeditor5-table#99.

@Reinmar
Copy link
Member

Reinmar commented Sep 4, 2018

OK, cool. So we can postpone this.

@100cm
Copy link

100cm commented Oct 31, 2018

why disallow image in table cell ? i think we need it...

@jodator
Copy link
Contributor Author

jodator commented Dec 6, 2018

Ref: #1331.

scofalik referenced this issue in ckeditor/ckeditor5-table Dec 20, 2018
Feature: Introduce images in tables. Closes #99.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-table Oct 9, 2019
@mlewand mlewand added this to the iteration 22 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:feature This issue reports a feature request (an idea for a new functionality or a missing option). package:table labels Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:table type:feature This issue reports a feature request (an idea for a new functionality or a missing option).
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants