Merge pull request #70 from ckeditor/t/69

Fix: Tab key should not delete selected text. Closes: #69.
ckeditor · Feb 6, 2017 · 8447f51 · 8447f51
2 parents 3be14d8 + b9e8e8c
commit 8447f51
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 0 deletions.
diff --git a/src/input.js b/src/input.js
@@ -286,6 +286,7 @@ const safeKeycodes = [
 	getCode( 'arrowRight' ),
 	getCode( 'arrowDown' ),
 	getCode( 'arrowLeft' ),
+	9,  // Tab
 	16, // Shift
 	17, // Ctrl
 	18, // Alt

diff --git a/tests/input.js b/tests/input.js
@@ -307,6 +307,18 @@ describe( 'Input feature', () => {
 			expect( getModelData( model ) ).to.equal( '<paragraph>fo[ob]ar</paragraph>' );
 		} );
 
+		// #69
+		it( 'should do nothing on tab key', () => {
+			model.enqueueChanges( () => {
+				model.selection.setRanges( [
+					ModelRange.createFromParentsAndOffsets( modelRoot.getChild( 0 ), 2, modelRoot.getChild( 0 ), 4 ) ] );
+			} );
+
+			view.fire( 'keydown', { keyCode: 9 } ); // Tab
+
+			expect( getModelData( model ) ).to.equal( '<paragraph>fo[ob]ar</paragraph>' );
+		} );
+
 		it( 'should do nothing if selection is collapsed', () => {
 			view.fire( 'keydown', { ctrlKey: true, keyCode: getCode( 'c' ) } );