Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IME] Character inserts twice after typing at the beginning of the word with inline styling #3109

Closed
Mgsy opened this issue Jan 2, 2018 · 1 comment · Fixed by ckeditor/ckeditor5-engine#1424
Closed

[IME] Character inserts twice after typing at the beginning of the word with inline styling #3109

Mgsy opened this issue Jan 2, 2018 · 1 comment · Fixed by ckeditor/ckeditor5-engine#1424
Labels
package:typing type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 18

Comments

@Mgsy
Copy link
Member

Mgsy commented Jan 2, 2018

Steps to reproduce

Windows

  1. http://localhost:8125/ckeditor5-core/tests/manual/article.html.
  2. Change the keyboard language to Hiragana.
  3. Put the caret at the beginning of the word with inline style (i.e. Bold).
  4. Press a to start the composition.

OS X

  1. http://localhost:8125/ckeditor5-core/tests/manual/article.html.
  2. Change the keyboard language to Hiragana.
  3. Put the caret at the beginning of the word with inline style (i.e. Bold).
  4. Press a to start the composition.
  5. Press a once again.

Current result

Character has been inserted twice.

GIF

bug_cke5

Other information

OS: Windows 10, MacOS X
Browser: Chrome, Opera
Release: 1.0.0-alpha2
@Mgsy Mgsy changed the title [Chrome][IME] Character inserts twice after typing in selected word with inline styling [Chrome][IME] Character inserts twice after typing at the beginning of the word with inline styling Jan 3, 2018
@f1ames
Copy link
Contributor

f1ames commented Feb 27, 2018

Tested on MacOS where it behaves similar (with some small differences). Safari (11.0.3 (11604.5.6.1.1)) works as described in the issue.

Chrome (64.0.3282.167)

First character doesn't start composition and then two characters are inserted after pressing a once:
feb-27-2018 14-10-27-chrome

Firefox (58.0.2 (64-bit))

First character is inserted starting a composition and then pressing a multiple times doesn't insert anything (however you can see IME panel is updated after each press). And after some more characters are inserted it shows whole inserted text:
feb-27-2018 14-11-45-firefox

@f1ames f1ames changed the title [Chrome][IME] Character inserts twice after typing at the beginning of the word with inline styling [IME] Character inserts twice after typing at the beginning of the word with inline styling Feb 27, 2018
Reinmar referenced this issue in ckeditor/ckeditor5-engine Jun 18, 2018
@Reinmar
Merge pull request #1424 from ckeditor/t/1417
457afde 
Fix: Renderer should avoid doing unnecessary DOM structure changes. Ensuring that the DOM gets updated less frequently fixes many issues with text composition. Closes #1417. Closes #1409. Closes #1349. Closes #1334. Closes #898. Closes ckeditor/ckeditor5-typing#129. Closes ckeditor/ckeditor5-typing#89. Closes #1427.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-typing Oct 9, 2019
@mlewand mlewand added this to the iteration 18 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:bug This issue reports a buggy (incorrect) behavior. package:typing labels Oct 9, 2019
@f1ames f1ames mentioned this issue Oct 11, 2019
Merged
@chanvuetto-t chanvuetto-t mentioned this issue Nov 15, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
package:typing type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 18
Development

Successfully merging a pull request may close this issue.

Avoid unnecessary DOM structure updates in renderer ckeditor/ckeditor5-engine
3 participants
@f1ames @mlewand @Mgsy