Contextual toolbar should not be shown when doing a selection

[Reinmar]

[Reinmar]

I've just talked with @oleq and @oskarwrobel and I'm a bit confused.

I don't understand why does CT listen to model's change:range. The aspect of making selection by dnd is purely view's stuff and handling it in the model is weird. E.g. the model does not know whether the mouse button is still down or up.

Also, we have the view's selectionChangeDone event which was meant to be improved to really reflect when the selection is being done. Maybe we should just work on this event to make it really reliable instead of workarounding this and creating similar issues (selCDone has the same issue as the debounced change:range used by CT).

[oskarwrobel]

In the first implementation, view#selectionChange and view#selectionChangeDone events were used, but problem was that those events were fired when style of text in selection has changed (like bold, italic...) and CT was blinking (now I see that renderer is improved and selectionChange is not fired in this scenario). The second problem is described here by @pjasiun.

I also tried to use view.selection#change but I had the same problem with blinking CT as above, besides view.selection#change is fired on external document changes and there is no way to identify that change is external.

Using model.selection#change:range solves above issues.

[CKEditorBot]

There has been no activity on this issue for the past year. We've marked it as stale and will close it in 30 days. We understand it may be relevant, so if you're interested in the solution, leave a comment or reaction under this issue.

[CKEditorBot]

There has been no activity on this issue for the past year. We've marked it as stale and will close it in 30 days. We understand it may still be relevant, so if you're interested in the solution, leave a comment or reaction under this issue.

[CKEditorBot]

We've closed your issue due to inactivity over the last year. We understand that the issue may still be relevant. If so, feel free to open a new one (and link this issue to it).