Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements in the components for contextual editor implementation #5364

Closed
oleq opened this issue May 24, 2017 · 0 comments · Fixed by ckeditor/ckeditor5-ui#237
Closed

Improvements in the components for contextual editor implementation #5364

oleq opened this issue May 24, 2017 · 0 comments · Fixed by ckeditor/ckeditor5-ui#237
Assignees
@oleq
Labels
package:ui type:improvement This issue reports a possible enhancement of an existing feature.
Milestone
iteration 11

Comments

@oleq
Copy link
Member

oleq commented May 24, 2017

There are several improvements to consider to improve the user experience in the contextual editor:

BalloonPanel

Some of the BalloonPanelView.defaultPositions names are misleading, e.g.

image

the second one should be northArrowSouthEast.

ContextualToolbar

  1. This issue should be fixed https://github.com/ckeditor/ckeditor5-ui/issues/234.
  2. The ContextualToolbar plugin should become more flexible when dealing with tight spaces, which means additional positions to BalloonPanelView.defaultPositions.

A follow-up of #402.
@oleq oleq self-assigned this May 24, 2017
szymonkups referenced this issue in ckeditor/ckeditor5-ui May 30, 2017
@szymonkups
Merge pull request #237 from ckeditor/t/236
737b55f 
Other: Improvements in the `BalloonPanelView`–based components for the balloon toolbar editor. Closes #236. Closes #234. Closes #224.

BREAKING CHANGE: The position names in `BalloonPanelView.defaultPositions` and their results have changed. Please refer to the latest API documentation to learn more.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-ui Oct 9, 2019
@mlewand mlewand added this to the iteration 11 milestone Oct 9, 2019
@mlewand mlewand added type:improvement This issue reports a possible enhancement of an existing feature. package:ui labels Oct 9, 2019
@oleq oleq mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oleq oleq

Labels
package:ui type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Milestone
iteration 11
2 participants
@oleq @mlewand