Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the Controller class #5266

Closed
Reinmar opened this issue Oct 24, 2016 · 2 comments · Fixed by ckeditor/ckeditor5-ui#100
Closed

Remove the Controller class #5266

Reinmar opened this issue Oct 24, 2016 · 2 comments · Fixed by ckeditor/ckeditor5-ui#100
Assignees
@oleq
Labels
package:ui type:task This issue reports a chore (non-production change) and other types of "todos".
Milestone
iteration 5

Comments

@Reinmar
Copy link
Member

Reinmar commented Oct 24, 2016

All changes required to remove the Controller class.

  1. View#createCollection().
  2. Add ViewCollection() (if needed).
  3. Make that ViewCollection instance can be used directly in a template and that view.someCollection.add( someView ) or remove( someView ).
  4. Verify init() and destroy() chains.
@pjasiun
Copy link

pjasiun commented Oct 24, 2016

Should fix https://github.com/ckeditor/ckeditor5-ui/issues/90 and https://github.com/ckeditor/ckeditor5-ui/issues/91.

@oleq
Copy link
Member

oleq commented Nov 7, 2016

package.json for the entire refac in https://github.com/ckeditor/ckeditor5/tree/mvc-refac branch.

@mlewand mlewand transferred this issue from ckeditor/ckeditor5-ui Oct 9, 2019
@mlewand mlewand added this to the iteration 5 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:task This issue reports a chore (non-production change) and other types of "todos". package:ui labels Oct 9, 2019
@oleq oleq mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oleq oleq

Labels
package:ui type:task This issue reports a chore (non-production change) and other types of "todos".
Projects
None yet
Milestone
iteration 5
Development

Successfully merging a pull request may close this issue.

t/95: Remove the Controller class ckeditor/ckeditor5-ui
4 participants
@Reinmar @oleq @pjasiun @mlewand