Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if we need batch types #2694

Closed
scofalik opened this issue Jun 22, 2016 · 1 comment
Closed

Check if we need batch types #2694

scofalik opened this issue Jun 22, 2016 · 1 comment
Labels
package:undo type:improvement This issue reports a possible enhancement of an existing feature.
Milestone

Comments

@scofalik
Copy link
Contributor

Undo introduces and uses two batch types at the moment: undo and redo batch types. They are needed for proper integration between commands and between deltas incoming from different sources.

I hope that we can at least get rid of redo batch and maybe even undo batch if we can use events fired by UndoCommand and RedoCommand and change undo/redo algorithm a bit. It was doable before but there were some problems with selection and ultimately it was easier for me to use batch types. But for me, batch types should be more general and having undo and redo batch types feels very bad.

@pjasiun
Copy link

pjasiun commented Jun 24, 2016

@pjasiun pjasiun closed this as completed Jun 24, 2016
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-undo Oct 9, 2019
@mlewand mlewand added this to the v0.1.0 milestone Oct 9, 2019
@mlewand mlewand added type:improvement This issue reports a possible enhancement of an existing feature. package:undo labels Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:undo type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Development

No branches or pull requests

3 participants