Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image upload placeholder SVG should be escaped #2821

Closed
szymonkups opened this issue Sep 28, 2017 · 0 comments · Fixed by ckeditor/ckeditor5-upload#57
Closed

Image upload placeholder SVG should be escaped #2821

szymonkups opened this issue Sep 28, 2017 · 0 comments · Fixed by ckeditor/ckeditor5-upload#57
Assignees
@szymonkups
Labels
package:upload type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 12

Comments

@szymonkups
Copy link
Contributor

We are using SVG image to present image upload placeholder. It is inserted directly into image's src attribute:

this.placeholder = 'data:image/svg+xml;utf8,' + uploadingPlaceholder;

This is not working on FF and Edge since we need to escape special characters from SVG.
@szymonkups szymonkups self-assigned this Sep 28, 2017
oskarwrobel referenced this issue in ckeditor/ckeditor5-upload Sep 28, 2017
@oskarwrobel
Merge pull request #57 from ckeditor/t/56
785e88b 
Fix: Placeholder is now correctly displayed on Firefox and Edge. Closes #56.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-upload Oct 9, 2019
@mlewand mlewand added this to the iteration 12 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:bug This issue reports a buggy (incorrect) behavior. package:upload labels Oct 9, 2019
@szymonkups szymonkups mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@szymonkups szymonkups

Labels
package:upload type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 12
Development

Successfully merging a pull request may close this issue.

Encoding image's placeholder SVG data ckeditor/ckeditor5-upload
2 participants
@szymonkups @mlewand