Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getOptimalPosition utility should consider limiter ancestors with overflow #4948

Closed
oleq opened this issue Apr 14, 2017 · 0 comments · Fixed by ckeditor/ckeditor5-utils#149
Closed

getOptimalPosition utility should consider limiter ancestors with overflow #4948

oleq opened this issue Apr 14, 2017 · 0 comments · Fixed by ckeditor/ckeditor5-utils#149
Assignees
@oleq
Labels
package:utils type:improvement This issue reports a possible enhancement of an existing feature.
Milestone
iteration 10

Comments

@oleq
Copy link
Member

oleq commented Apr 14, 2017

Additionally getOptimalPosition() could check all the ancestors of the limiter which have overflow different than visible and intersect all their rects one by one up to window to find the real visible area which is available to position the BalloonPanel. That would, in most cases, make the limiter configuration obsolete.

A follow-up of https://github.com/ckeditor/ckeditor5-ui/issues/173.
@oleq oleq self-assigned this Apr 14, 2017
@oleq oleq changed the title getOptimalPosition utility should consider parents with overflow getOptimalPosition utility should consider limiter ancestors with overflow Apr 18, 2017
oleq referenced this issue in ckeditor/ckeditor5-utils Apr 18, 2017
@oleq
Fix: The getOptimalPosition utility should consider limiter ancestors…
ee4b394 
… with CSS overflow. Closes #148.
oskarwrobel referenced this issue in ckeditor/ckeditor5-utils Apr 19, 2017
@oskarwrobel
Fix: The getOptimalPosition utility should consider limiter ancesto…
6bf1741 
…rs with CSS overflow. Closes #148.

T/148: getOptimalPosition utility should consider limiter ancestors with CSS overflow. Closes #148.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-utils Oct 9, 2019
@mlewand mlewand added this to the iteration 10 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:improvement This issue reports a possible enhancement of an existing feature. package:utils labels Oct 9, 2019
@oleq oleq mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oleq oleq

Labels
package:utils type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Milestone
iteration 10
2 participants
@oleq @mlewand