Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The FocusTracker must not have dependency in ui #4916

Closed
Reinmar opened this issue Nov 4, 2016 · 2 comments · Fixed by ckeditor/ckeditor5-utils#99
Closed

The FocusTracker must not have dependency in ui #4916

Reinmar opened this issue Nov 4, 2016 · 2 comments · Fixed by ckeditor/ckeditor5-utils#99
Labels
package:utils type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 5

Comments

@Reinmar
Copy link
Member

Reinmar commented Nov 4, 2016

https://github.com/ckeditor/ckeditor5-utils/blob/c8ab18b6141e49a69c362c46128127788fba985a/src/focustracker.js#L8-L8

This means that DomEmitterMixin will need to be moved to utils.
@Reinmar
Copy link
Member Author

Reinmar commented Nov 14, 2016

I forgot to remove ckeditor5-ui from utils deps. I now pushed one more t/95 branch to check on CI whether ui is needed (should not be).

@Reinmar
Copy link
Member Author

Reinmar commented Nov 14, 2016

It's clean so I'm merging it.

@mlewand mlewand transferred this issue from ckeditor/ckeditor5-utils Oct 9, 2019
@mlewand mlewand added this to the iteration 5 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:bug This issue reports a buggy (incorrect) behavior. package:utils labels Oct 9, 2019
@Reinmar Reinmar mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
package:utils type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 5
Development

Successfully merging a pull request may close this issue.

DomEmitterMixin was moved from ckeditor5-ui. ckeditor/ckeditor5-utils
2 participants
@Reinmar @mlewand